Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR

2017-08-23 Thread Bjorn Helgaas
On Wed, Aug 23, 2017 at 05:51:19PM -0400, Sinan Kaya wrote: > On 8/23/2017 5:38 PM, Bjorn Helgaas wrote: > > If we increase the timeout, is there still value in adding the > > pci_bus_wait_crs() stuff? I'm not sure there is. > > I agree increasing the timeout is more than enough for FLR case. I

Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR

2017-08-23 Thread Sinan Kaya
On 8/23/2017 5:38 PM, Bjorn Helgaas wrote: > If we increase the timeout, is there still value in adding the > pci_bus_wait_crs() stuff? I'm not sure there is. I agree increasing the timeout is more than enough for FLR case. However, I was considering the wait and pending functions as a utility

Re: [PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR

2017-08-23 Thread Bjorn Helgaas
On Wed, Aug 23, 2017 at 12:56:10AM -0400, Sinan Kaya wrote: > Sporadic reset issues have been observed with Intel 750 NVMe drive while > assigning the physical function to the guest machine. The sequence of > events observed is as follows: > > - perform a Function Level Reset (FLR) > - sleep

[PATCH V12 4/5] PCI: Handle CRS ("device not ready") returned by device after FLR

2017-08-22 Thread Sinan Kaya
Sporadic reset issues have been observed with Intel 750 NVMe drive while assigning the physical function to the guest machine. The sequence of events observed is as follows: - perform a Function Level Reset (FLR) - sleep up to 1000ms total - read ~0 from PCI_COMMAND - warn that the device