Re: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-10 Thread Linus Walleij
On Thu, Nov 9, 2017 at 8:12 AM, Adrian Hunter wrote: > On 08/11/17 11:24, Linus Walleij wrote: >> On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter >> wrote: >> >>> Add CQHCI initialization and implement CQHCI operations for Intel GLK. >>> >>>

Re: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-10 Thread Linus Walleij
On Thu, Nov 9, 2017 at 8:12 AM, Adrian Hunter wrote: > On 08/11/17 11:24, Linus Walleij wrote: >> On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter >> wrote: >> >>> Add CQHCI initialization and implement CQHCI operations for Intel GLK. >>> >>> Signed-off-by: Adrian Hunter >> >> This patch seems OK

Re: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-09 Thread Ulf Hansson
On 3 November 2017 at 14:20, Adrian Hunter wrote: > Add CQHCI initialization and implement CQHCI operations for Intel GLK. > > Signed-off-by: Adrian Hunter This looks good to me! Kind regards Uffe > --- > drivers/mmc/host/Kconfig |

Re: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-09 Thread Ulf Hansson
On 3 November 2017 at 14:20, Adrian Hunter wrote: > Add CQHCI initialization and implement CQHCI operations for Intel GLK. > > Signed-off-by: Adrian Hunter This looks good to me! Kind regards Uffe > --- > drivers/mmc/host/Kconfig | 1 + > drivers/mmc/host/sdhci-pci-core.c | 155 >

Re: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-08 Thread Adrian Hunter
On 08/11/17 11:24, Linus Walleij wrote: > On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter wrote: > >> Add CQHCI initialization and implement CQHCI operations for Intel GLK. >> >> Signed-off-by: Adrian Hunter > > This patch seems OK in context,

Re: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-08 Thread Adrian Hunter
On 08/11/17 11:24, Linus Walleij wrote: > On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter wrote: > >> Add CQHCI initialization and implement CQHCI operations for Intel GLK. >> >> Signed-off-by: Adrian Hunter > > This patch seems OK in context, but it merely illustrates the > weirdness of

Re: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-08 Thread Linus Walleij
On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter wrote: > Add CQHCI initialization and implement CQHCI operations for Intel GLK. > > Signed-off-by: Adrian Hunter This patch seems OK in context, but it merely illustrates the weirdness of

Re: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-08 Thread Linus Walleij
On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter wrote: > Add CQHCI initialization and implement CQHCI operations for Intel GLK. > > Signed-off-by: Adrian Hunter This patch seems OK in context, but it merely illustrates the weirdness of .[runtime]_suspend/resume calling into CQE-specific APIs

[PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-03 Thread Adrian Hunter
Add CQHCI initialization and implement CQHCI operations for Intel GLK. Signed-off-by: Adrian Hunter --- drivers/mmc/host/Kconfig | 1 + drivers/mmc/host/sdhci-pci-core.c | 155 +- 2 files changed, 155 insertions(+), 1

[PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK

2017-11-03 Thread Adrian Hunter
Add CQHCI initialization and implement CQHCI operations for Intel GLK. Signed-off-by: Adrian Hunter --- drivers/mmc/host/Kconfig | 1 + drivers/mmc/host/sdhci-pci-core.c | 155 +- 2 files changed, 155 insertions(+), 1 deletion(-) diff --git