Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-19 Thread Bart Van Assche
On 2/19/19 5:17 PM, Ming Lei wrote: On Tue, Feb 19, 2019 at 08:28:19AM -0800, Bart Van Assche wrote: With this patch applied test nvmeof-mp/002 fails as follows: [ 694.700400] kernel BUG at lib/sg_pool.c:103! [ 694.705932] invalid opcode: [#1] PREEMPT SMP KASAN [ 694.708297] CPU: 2 PID:

Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-19 Thread Ming Lei
On Tue, Feb 19, 2019 at 08:28:19AM -0800, Bart Van Assche wrote: > On Sun, 2019-02-17 at 21:11 +0800, Ming Lei wrote: > > The following patch should fix this issue: > > > > > > diff --git a/block/blk-merge.c b/block/blk-merge.c > > index bed065904677..066b66430523 100644 > > --- a/block/blk-merge

Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-19 Thread Bart Van Assche
On Sun, 2019-02-17 at 21:11 +0800, Ming Lei wrote: > The following patch should fix this issue: > > > diff --git a/block/blk-merge.c b/block/blk-merge.c > index bed065904677..066b66430523 100644 > --- a/block/blk-merge.c > +++ b/block/blk-merge.c > @@ -363,13 +363,15 @@ static unsigned int __blk_

Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-17 Thread Ming Lei
On Sun, Feb 17, 2019 at 09:13:32PM +0800, Ming Lei wrote: > On Fri, Feb 15, 2019 at 10:59:47AM -0700, Jens Axboe wrote: > > On 2/15/19 10:14 AM, Bart Van Assche wrote: > > > On Fri, 2019-02-15 at 08:49 -0700, Jens Axboe wrote: > > >> On 2/15/19 4:13 AM, Ming Lei wrote: > > >>> This patchset brings

Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-17 Thread Ming Lei
On Fri, Feb 15, 2019 at 10:59:47AM -0700, Jens Axboe wrote: > On 2/15/19 10:14 AM, Bart Van Assche wrote: > > On Fri, 2019-02-15 at 08:49 -0700, Jens Axboe wrote: > >> On 2/15/19 4:13 AM, Ming Lei wrote: > >>> This patchset brings multi-page bvec into block layer: > >> > >> Applied, thanks Ming. Le

Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-17 Thread Ming Lei
On Fri, Feb 15, 2019 at 09:14:15AM -0800, Bart Van Assche wrote: > On Fri, 2019-02-15 at 08:49 -0700, Jens Axboe wrote: > > On 2/15/19 4:13 AM, Ming Lei wrote: > > > This patchset brings multi-page bvec into block layer: > > > > Applied, thanks Ming. Let's hope it sticks! > > Hi Jens and Ming, >

Re: [PATCH V15 00/18] block: support multi-page bvec

2019-02-17 Thread Ming Lei
On Fri, Feb 15, 2019 at 03:51:26PM +0100, Christoph Hellwig wrote: > I still don't understand why mp_bvec_last_segment isn't simply > called bvec_last_segment as there is no conflict. But I don't > want to hold this series up on that as there only are two users > left and we can always just fix it

Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-15 Thread Jens Axboe
On 2/15/19 10:14 AM, Bart Van Assche wrote: > On Fri, 2019-02-15 at 08:49 -0700, Jens Axboe wrote: >> On 2/15/19 4:13 AM, Ming Lei wrote: >>> This patchset brings multi-page bvec into block layer: >> >> Applied, thanks Ming. Let's hope it sticks! > > Hi Jens and Ming, > > Test nvmeof-mp/002 fails

Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-15 Thread Bart Van Assche
On Fri, 2019-02-15 at 08:49 -0700, Jens Axboe wrote: > On 2/15/19 4:13 AM, Ming Lei wrote: > > This patchset brings multi-page bvec into block layer: > > Applied, thanks Ming. Let's hope it sticks! Hi Jens and Ming, Test nvmeof-mp/002 fails with Jens' for-next branch from this morning. I have no

Re: [PATCH V15 00/18] block: support multi-page bvec

2019-02-15 Thread Jens Axboe
On 2/15/19 4:13 AM, Ming Lei wrote: > Hi, > > This patchset brings multi-page bvec into block layer: > > 1) what is multi-page bvec? > > Multipage bvecs means that one 'struct bio_bvec' can hold multiple pages > which are physically contiguous instead of one single page used in linux > kernel fo

Re: [PATCH V15 00/18] block: support multi-page bvec

2019-02-15 Thread Christoph Hellwig
I still don't understand why mp_bvec_last_segment isn't simply called bvec_last_segment as there is no conflict. But I don't want to hold this series up on that as there only are two users left and we can always just fix it up later.

[PATCH V15 00/18] block: support multi-page bvec

2019-02-15 Thread Ming Lei
Hi, This patchset brings multi-page bvec into block layer: 1) what is multi-page bvec? Multipage bvecs means that one 'struct bio_bvec' can hold multiple pages which are physically contiguous instead of one single page used in linux kernel for long time. 2) why is multi-page bvec introduced? K