Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-17 Thread Tirumalesh Chalamarla
On 02/17/2016 12:00 PM, Tejun Heo wrote: Hello, David. On Wed, Feb 17, 2016 at 10:57:50AM -0800, David Daney wrote: If the ahci/ata maintainers insist, we can add that. I don't mind whether it is CONFIG_ARM64 or something more specific but I think it's a good idea to gate it some way. Alre

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-17 Thread Tejun Heo
Hello, David. On Wed, Feb 17, 2016 at 10:57:50AM -0800, David Daney wrote: > If the ahci/ata maintainers insist, we can add that. I don't mind whether it is CONFIG_ARM64 or something more specific but I think it's a good idea to gate it some way. > If at all possible, please write plain argume

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-17 Thread David Daney
On 02/17/2016 03:29 AM, Will Deacon wrote: On Tue, Feb 16, 2016 at 03:13:32PM -0800, Tirumalesh Chalamarla wrote: On 02/16/2016 01:14 PM, Robert Richter wrote: CONFIG_CAVIUM_ERRATUM_22536 is exactly that you need. It is not only used for core interrupts, e.g. also for gicv3 devices (and now als

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-17 Thread Will Deacon
On Tue, Feb 16, 2016 at 03:13:32PM -0800, Tirumalesh Chalamarla wrote: > On 02/16/2016 01:14 PM, Robert Richter wrote: > >CONFIG_CAVIUM_ERRATUM_22536 is exactly that you need. It is not only > >used for core interrupts, e.g. also for gicv3 devices (and now also > >for ahci). Non-core errata (e.g. C

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-16 Thread Tirumalesh Chalamarla
On 02/16/2016 01:14 PM, Robert Richter wrote: On 16.02.16 11:50:44, Tirumalesh Chalamarla wrote: On 02/16/2016 11:38 AM, David Daney wrote: On 02/16/2016 11:14 AM, Tirumalesh Chalamarla wrote: On 02/16/2016 06:42 AM, Robert Richter wrote: On 15.02.16 13:30:41, Tejun Heo wrote: On Sun,

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-16 Thread Robert Richter
On 16.02.16 11:50:44, Tirumalesh Chalamarla wrote: > > > On 02/16/2016 11:38 AM, David Daney wrote: > >On 02/16/2016 11:14 AM, Tirumalesh Chalamarla wrote: > >> > >> > >>On 02/16/2016 06:42 AM, Robert Richter wrote: > >>>On 15.02.16 13:30:41, Tejun Heo wrote: > On Sun, Feb 14, 2016 at 07:36:1

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-16 Thread Tirumalesh Chalamarla
On 02/16/2016 11:38 AM, David Daney wrote: On 02/16/2016 11:14 AM, Tirumalesh Chalamarla wrote: On 02/16/2016 06:42 AM, Robert Richter wrote: On 15.02.16 13:30:41, Tejun Heo wrote: On Sun, Feb 14, 2016 at 07:36:18PM -0800, Tirumalesh Chalamarla wrote: There is no need for special Driver,

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-16 Thread David Daney
On 02/16/2016 11:14 AM, Tirumalesh Chalamarla wrote: On 02/16/2016 06:42 AM, Robert Richter wrote: On 15.02.16 13:30:41, Tejun Heo wrote: On Sun, Feb 14, 2016 at 07:36:18PM -0800, Tirumalesh Chalamarla wrote: There is no need for special Driver, AHCI is sufficient for ThunderX, the file only

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-16 Thread Tirumalesh Chalamarla
On 02/16/2016 06:42 AM, Robert Richter wrote: On 15.02.16 13:30:41, Tejun Heo wrote: On Sun, Feb 14, 2016 at 07:36:18PM -0800, Tirumalesh Chalamarla wrote: There is no need for special Driver, AHCI is sufficient for ThunderX, the file only contains this interrupt handler, is it preferable if

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-16 Thread Robert Richter
On 15.02.16 13:30:41, Tejun Heo wrote: > On Sun, Feb 14, 2016 at 07:36:18PM -0800, Tirumalesh Chalamarla wrote: > > There is no need for special Driver, AHCI is sufficient for ThunderX, the > > file only contains this interrupt handler, > > is it preferable if this interrupt handler in libahci.c wi

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-15 Thread Tejun Heo
Hello, Tirumalesh. On Sun, Feb 14, 2016 at 07:36:18PM -0800, Tirumalesh Chalamarla wrote: > There is no need for special Driver, AHCI is sufficient for ThunderX, the > file only contains this interrupt handler, > is it preferable if this interrupt handler in libahci.c with others, instead > of sep

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-14 Thread Tirumalesh Chalamarla
On 02/14/2016 09:01 AM, Tejun Heo wrote: Hello, On Fri, Feb 12, 2016 at 03:20:30PM -0800, tchalama...@caviumnetworks.com wrote: diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 546a369..76e310e 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1560,6 +1560,9 @@ static int

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-14 Thread Tejun Heo
Hello, On Fri, Feb 12, 2016 at 03:20:30PM -0800, tchalama...@caviumnetworks.com wrote: > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index 546a369..76e310e 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -1560,6 +1560,9 @@ static int ahci_init_one(struct pci_dev *pdev,

Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-13 Thread Sergei Shtylyov
Hello. On 2/13/2016 2:20 AM, tchalama...@caviumnetworks.com wrote: From: Tirumalesh Chalamarla Due to Errata in ThunderX, HOST_IRQ_STAT should be cleared before leaving the interrupt handler. The patch attempts to satisfy the need. Changes from V1: - Rebased on top of libata/for-4.6

[PATCH V2] AHCI: Workaround for ThunderX Errata#22536

2016-02-12 Thread tchalamarla
From: Tirumalesh Chalamarla Due to Errata in ThunderX, HOST_IRQ_STAT should be cleared before leaving the interrupt handler. The patch attempts to satisfy the need. Changes from V1: - Rebased on top of libata/for-4.6 - Moved ThunderX intr handler to new file Signed-off-by: Tirum