Re: [PATCH V2] ARM: mvebu: at least report the kzalloc failure

2019-04-17 Thread Nicholas Mc Guire
On Wed, Apr 17, 2019 at 02:07:44PM +0200, Gregory CLEMENT wrote: > Hi Nicholas, > > Nicholas Mc Guire writes: > > > On Tue, Apr 16, 2019 at 03:39:57PM +0200, Andrew Lunn wrote: > >> On Tue, Apr 16, 2019 at 05:56:31AM +0200, Nicholas Mc Guire wrote: > >> > >> > Note that this will trigger a chec

Re: [PATCH V2] ARM: mvebu: at least report the kzalloc failure

2019-04-17 Thread Gregory CLEMENT
Hi Nicholas, Nicholas Mc Guire writes: > On Tue, Apr 16, 2019 at 03:39:57PM +0200, Andrew Lunn wrote: >> On Tue, Apr 16, 2019 at 05:56:31AM +0200, Nicholas Mc Guire wrote: >> >> > Note that this will trigger a checkpatch WARNING >> > "WARNING: Possible unnecessary 'out of memory' message" >> >

Re: [PATCH V2] ARM: mvebu: at least report the kzalloc failure

2019-04-17 Thread Nicholas Mc Guire
On Tue, Apr 16, 2019 at 03:39:57PM +0200, Andrew Lunn wrote: > On Tue, Apr 16, 2019 at 05:56:31AM +0200, Nicholas Mc Guire wrote: > > > Note that this will trigger a checkpatch WARNING > > "WARNING: Possible unnecessary 'out of memory' message" > > but comparing the oops with an without the one-li

Re: [PATCH V2] ARM: mvebu: at least report the kzalloc failure

2019-04-16 Thread Andrew Lunn
On Tue, Apr 16, 2019 at 05:56:31AM +0200, Nicholas Mc Guire wrote: > Note that this will trigger a checkpatch WARNING > "WARNING: Possible unnecessary 'out of memory' message" > but comparing the oops with an without the one-line pr_err I would > argue that it makes sense to include it: Hi Nichol

[PATCH V2] ARM: mvebu: at least report the kzalloc failure

2019-04-15 Thread Nicholas Mc Guire
Although it is very unlikely that the allocation during init would fail any such failure should point to the original cause to allow easier understanding of the ensuing null-pointer dereference splat. Signed-off-by: Nicholas Mc Guire --- Problem located with experimental coccinelle script V2: R