Re: [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-09-08 Thread Radosław Biernacki
Thanks for the tip! Let me reformat the patch. wt., 8 wrz 2020 o 20:06 Pierre-Louis Bossart napisał(a): > > > > On 9/8/20 12:42 PM, Radosław Biernacki wrote: > > Sorry for missing the response for so long. > > Somehow lost this thread in my mailbox. > > That happens to all of us! > > > śr., 6

Re: [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-09-08 Thread Pierre-Louis Bossart
On 9/8/20 12:42 PM, Radosław Biernacki wrote: Sorry for missing the response for so long. Somehow lost this thread in my mailbox. That happens to all of us! śr., 6 maj 2020 o 00:04 Pierre-Louis Bossart napisał(a): This single fix address two issues on machines with nau88125: 1) Audio

Re: [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-09-08 Thread Radosław Biernacki
Sorry for missing the response for so long. Somehow lost this thread in my mailbox. śr., 6 maj 2020 o 00:04 Pierre-Louis Bossart napisał(a): > > > >>> This single fix address two issues on machines with nau88125: > >>> 1) Audio distortion, due to lack of required clock rate on MCLK line > >>> 2)

Re: [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-05-05 Thread Pierre-Louis Bossart
This single fix address two issues on machines with nau88125: 1) Audio distortion, due to lack of required clock rate on MCLK line 2) Loud audible "pops" on headphones if there is no sysclk during nau8825 playback power up sequence Explanation for: 1) Due to Skylake HW limitation, MCLK

Re: [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-05-05 Thread Cezary Rojewski
2) Currently Skylake does not output MCLK/FS when the back-end DAI op hw_param is called, so we cannot switch to MCLK/FS in hw_param. This patch reduces pop by letting nau8825 keep using its internal VCO clock during widget power up sequence, until SNDRV_PCM_TRIGGER_START when

Re: [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-05-05 Thread Radosław Biernacki
Thank you Pierre for the review! answers inline pt., 1 maj 2020 o 22:16 Pierre-Louis Bossart wrote: > > > > On 5/1/20 2:31 PM, Radoslaw Biernacki wrote: > > This single fix address two issues on machines with nau88125: > > 1) Audio distortion, due to lack of required clock rate on MCLK line > >

Re: [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-05-02 Thread kbuild test robot
Hi Radoslaw, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on asoc/for-next] [also build test WARNING on sound/for-next v5.7-rc3 next-20200501] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also

Re: [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-05-01 Thread Pierre-Louis Bossart
On 5/1/20 2:31 PM, Radoslaw Biernacki wrote: This single fix address two issues on machines with nau88125: 1) Audio distortion, due to lack of required clock rate on MCLK line 2) Loud audible "pops" on headphones if there is no sysclk during nau8825 playback power up sequence Explanation

[PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine

2020-05-01 Thread Radoslaw Biernacki
This single fix address two issues on machines with nau88125: 1) Audio distortion, due to lack of required clock rate on MCLK line 2) Loud audible "pops" on headphones if there is no sysclk during nau8825 playback power up sequence Explanation for: 1) Due to Skylake HW limitation, MCLK pin can