Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Mark Brown
On Wed, Mar 10, 2021 at 07:17:13PM +, Jon Hunter wrote: > On 10/03/2021 18:37, Pierre-Louis Bossart wrote: > > +EXPORT_SYMBOL_GPL(dmi_available); > > -   if (!is_acpi_device_node(card->dev->fwnode)) > > +   if (!dmi_available) > Sounds good to me. I would have done the same if I had

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Jon Hunter
On 10/03/2021 18:37, Pierre-Louis Bossart wrote: > Build time dependencies aren't going to help anything, arm64 (and to my understanding some future x86 systems, LynxPoint IIRC) supports both DT and ACPI and so you have kernels built with support for both. >> >>> well, that's

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Pierre-Louis Bossart
Build time dependencies aren't going to help anything, arm64 (and to my understanding some future x86 systems, LynxPoint IIRC) supports both DT and ACPI and so you have kernels built with support for both. well, that's what I suggested initially: if (is_of_node(card->dev->fwnode))

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Mark Brown
On Wed, Mar 10, 2021 at 11:50:13AM -0600, Pierre-Louis Bossart wrote: > On 3/10/21 10:52 AM, Mark Brown wrote: > > Build time dependencies aren't going to help anything, arm64 (and to my > > understanding some future x86 systems, LynxPoint IIRC) supports both DT > > and ACPI and so you have

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Pierre-Louis Bossart
On 3/10/21 10:52 AM, Mark Brown wrote: On Wed, Mar 10, 2021 at 10:41:18AM -0600, Pierre-Louis Bossart wrote: would this work? if (!IS_ENABLED(CONFIG_DMI)) return 0; Build time dependencies aren't going to help anything, arm64 (and to my understanding some future x86 systems,

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Mark Brown
On Wed, Mar 10, 2021 at 10:41:18AM -0600, Pierre-Louis Bossart wrote: > would this work? > if (!IS_ENABLED(CONFIG_DMI)) > return 0; Build time dependencies aren't going to help anything, arm64 (and to my understanding some future x86 systems, LynxPoint IIRC) supports both DT and ACPI and so

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Mark Brown
On Wed, Mar 10, 2021 at 05:37:25PM +0100, Takashi Iwai wrote: > Mark Brown wrote: > > > did you mean if (!IS_ENABLED(CONFIG_ACPI)) ? > > Is there a runtime check? > Well, basically both DMI and ACPI are completely different things, so > I don't think it's right to check the availability of ACPI

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Pierre-Louis Bossart
On 3/10/21 10:37 AM, Takashi Iwai wrote: On Wed, 10 Mar 2021 17:18:14 +0100, Mark Brown wrote: On Wed, Mar 10, 2021 at 09:44:07AM -0600, Pierre-Louis Bossart wrote: On 3/10/21 7:35 AM, Mark Brown wrote: Just change it to a system level check for ACPI, checking for OF would leave

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Takashi Iwai
On Wed, 10 Mar 2021 17:18:14 +0100, Mark Brown wrote: > > On Wed, Mar 10, 2021 at 09:44:07AM -0600, Pierre-Louis Bossart wrote: > > On 3/10/21 7:35 AM, Mark Brown wrote: > > > > Just change it to a system level check for ACPI, checking for OF would > > > leave problems for board files or any

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Mark Brown
On Wed, Mar 10, 2021 at 09:44:07AM -0600, Pierre-Louis Bossart wrote: > On 3/10/21 7:35 AM, Mark Brown wrote: > > Just change it to a system level check for ACPI, checking for OF would > > leave problems for board files or any other alternative firmware > > interfaces. > did you mean if

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Pierre-Louis Bossart
On 3/10/21 7:35 AM, Mark Brown wrote: On Tue, Mar 09, 2021 at 01:41:45PM -0600, Pierre-Louis Bossart wrote: The problem is that the cards are platform devices created by the parent (which itself may be a PCI or ACPI device) and have nothing to do with ACPI. Could we flip the logic and

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-10 Thread Mark Brown
On Tue, Mar 09, 2021 at 01:41:45PM -0600, Pierre-Louis Bossart wrote: > The problem is that the cards are platform devices created by the parent > (which itself may be a PCI or ACPI device) and have nothing to do with ACPI. > Could we flip the logic and instead explicitly detect OF devices? That

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-09 Thread Pierre-Louis Bossart
On 3/3/21 5:55 AM, Jon Hunter wrote: Many systems do not use ACPI and hence do not provide a DMI table. On non-ACPI systems a warning, such as the following, is printed on boot. WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name! The variable 'dmi_available' is not

Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-03 Thread Mark Brown
On Wed, 3 Mar 2021 11:55:26 +, Jon Hunter wrote: > Many systems do not use ACPI and hence do not provide a DMI table. On > non-ACPI systems a warning, such as the following, is printed on boot. > > WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name! > > The variable

[PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present

2021-03-03 Thread Jon Hunter
Many systems do not use ACPI and hence do not provide a DMI table. On non-ACPI systems a warning, such as the following, is printed on boot. WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name! The variable 'dmi_available' is not exported and so currently cannot be used by