Re: [PATCH V2] KVM/x86: Check input paging mode when cs.l is set

2017-12-14 Thread Lan, Tianyu
On 12/14/2017 7:41 PM, Paolo Bonzini wrote: On 14/12/2017 04:55, Lan Tianyu wrote: +* When EFER.LME and CR0.PG are set, CR4.PAE and EFER.LMA +* must be set. +*/ + if ((sregs->efer & EFER_LME) && (sregs->cr0 & X86_CR0_PG_BIT)) { + if (!(sregs->cr4 & X

Re: [PATCH V2] KVM/x86: Check input paging mode when cs.l is set

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 04:55, Lan Tianyu wrote: > + * When EFER.LME and CR0.PG are set, CR4.PAE and EFER.LMA > + * must be set. > + */ > + if ((sregs->efer & EFER_LME) && (sregs->cr0 & X86_CR0_PG_BIT)) { > + if (!(sregs->cr4 & X86_CR4_PAE_BIT)) > + return -

[PATCH V2] KVM/x86: Check input paging mode when cs.l is set

2017-12-14 Thread Lan Tianyu
Reported by syzkaller: WARNING: CPU: 0 PID: 27962 at arch/x86/kvm/emulate.c:5631 x86_emulate_insn+0x557/0x15f0 [kvm] Modules linked in: kvm_intel kvm [last unloaded: kvm] CPU: 0 PID: 27962 Comm: syz-executor Tainted: GB W 4.15.0-rc2-next-20171208+ #32 Hardware name: I