Re: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

2017-03-03 Thread okaya
On 2017-03-03 04:43, Patel, Mayurkumar wrote: Hi Kaya Hi Mayurkumar On 3/2/2017 11:05 AM, Patel, Mayurkumar wrote: Hi Bjorn, On 2/28/2017 1:57 PM, Patel, Mayurkumar wrote: I was trying to figure out when to use saved values vs. the values in registers by looking at the enable_cnt. enable

RE: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

2017-03-03 Thread Patel, Mayurkumar
Hi Kaya > >Hi Mayurkumar > >On 3/2/2017 11:05 AM, Patel, Mayurkumar wrote: >>> >>> Hi Bjorn, >>> >>> On 2/28/2017 1:57 PM, Patel, Mayurkumar wrote: > I was trying to figure out when to use saved values vs. the values in > registers by looking at the enable_cnt. > enable_cnt is 0 during

Re: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

2017-03-02 Thread Sinan Kaya
Hi Mayurkumar On 3/2/2017 11:05 AM, Patel, Mayurkumar wrote: >> >> Hi Bjorn, >> >> On 2/28/2017 1:57 PM, Patel, Mayurkumar wrote: I was trying to figure out when to use saved values vs. the values in registers by looking at the enable_cnt. enable_cnt is 0 during boot on my system. >

RE: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

2017-03-02 Thread Patel, Mayurkumar
> >Hi Bjorn, > >On 2/28/2017 1:57 PM, Patel, Mayurkumar wrote: >>> I was trying to figure out when to use saved values vs. the values in >>> registers by looking at the enable_cnt. >>> enable_cnt is 0 during boot on my system. >> enable_cnt for the root port on my system is set to 1 for "root port"

Re: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

2017-03-01 Thread Sinan Kaya
Hi Bjorn, On 2/28/2017 1:57 PM, Patel, Mayurkumar wrote: >> I was trying to figure out when to use saved values vs. the values in >> registers by looking at the enable_cnt. >> enable_cnt is 0 during boot on my system. > enable_cnt for the root port on my system is set to 1 for "root port" already

RE: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

2017-02-28 Thread Patel, Mayurkumar
> >On 2/28/2017 6:03 AM, Patel, Mayurkumar wrote: >>> - /* Save default state */ >>> - link->aspm_default = link->aspm_enabled; >> But, I am finding a problem with this change, if Policy is set to default, >> BIOS enables ASPM L1, but pcie_config_aspm_link() disables ASPM L1 >> due to link->asp

Re: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

2017-02-28 Thread Sinan Kaya
On 2/28/2017 6:03 AM, Patel, Mayurkumar wrote: >> -/* Save default state */ >> -link->aspm_default = link->aspm_enabled; > But, I am finding a problem with this change, if Policy is set to default, > BIOS enables ASPM L1, but pcie_config_aspm_link() disables ASPM L1 > due to link->aspm_enab

RE: [PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

2017-02-28 Thread Patel, Mayurkumar
> >When the operating system is booted with the default ASPM policy >(POLICY_DEFAULT), the current code is determining the ASPM policy >set up by the BIOS by querying the enable/disable states from ASPM >registers. > >In the case of hotplug removal, the ASPM registers get cleared by >calling the pc

[PATCH V2] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT

2017-01-31 Thread Sinan Kaya
When the operating system is booted with the default ASPM policy (POLICY_DEFAULT), the current code is determining the ASPM policy set up by the BIOS by querying the enable/disable states from ASPM registers. In the case of hotplug removal, the ASPM registers get cleared by calling the pcie_aspm_e