Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-30 Thread Bjorn Helgaas
On Sat, Jun 30, 2018 at 10:45:21AM -0400, Sinan Kaya wrote: > On 6/29/2018 8:49 PM, Bjorn Helgaas wrote: > > On Tue, Jun 19, 2018 at 10:14:46PM -0400, Sinan Kaya wrote: > >> A PCIe endpoint carries the process address space identifier (PASID) in > >> the TLP prefix as part of the memory read/write

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-30 Thread Bjorn Helgaas
On Sat, Jun 30, 2018 at 10:45:21AM -0400, Sinan Kaya wrote: > On 6/29/2018 8:49 PM, Bjorn Helgaas wrote: > > On Tue, Jun 19, 2018 at 10:14:46PM -0400, Sinan Kaya wrote: > >> A PCIe endpoint carries the process address space identifier (PASID) in > >> the TLP prefix as part of the memory read/write

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-30 Thread Sinan Kaya
On 6/29/2018 8:49 PM, Bjorn Helgaas wrote: > On Tue, Jun 19, 2018 at 10:14:46PM -0400, Sinan Kaya wrote: >> A PCIe endpoint carries the process address space identifier (PASID) in >> the TLP prefix as part of the memory read/write transaction. The address >> information in the TLP is relevant only

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-30 Thread Sinan Kaya
On 6/29/2018 8:49 PM, Bjorn Helgaas wrote: > On Tue, Jun 19, 2018 at 10:14:46PM -0400, Sinan Kaya wrote: >> A PCIe endpoint carries the process address space identifier (PASID) in >> the TLP prefix as part of the memory read/write transaction. The address >> information in the TLP is relevant only

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-29 Thread Bjorn Helgaas
On Tue, Jun 19, 2018 at 10:14:46PM -0400, Sinan Kaya wrote: > A PCIe endpoint carries the process address space identifier (PASID) in > the TLP prefix as part of the memory read/write transaction. The address > information in the TLP is relevant only for a given PASID context. > > An IOMMU takes

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-29 Thread Bjorn Helgaas
On Tue, Jun 19, 2018 at 10:14:46PM -0400, Sinan Kaya wrote: > A PCIe endpoint carries the process address space identifier (PASID) in > the TLP prefix as part of the memory read/write transaction. The address > information in the TLP is relevant only for a given PASID context. > > An IOMMU takes

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-19 Thread Sinan Kaya
On 6/19/2018 11:02 PM, Timur Tabi wrote: > On 6/19/18 9:14 PM, Sinan Kaya wrote: >> +    if (!(cap & PCI_EXP_DEVCAP2_E2ETLP)) >> +    return; >> + >> +    dev->eetlp_prefix = 1; > > How about: > > if (cap & PCI_EXP_DEVCAP2_E2ETLP) >     dev->eetlp_prefix = 1; > Both works. I'll

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-19 Thread Sinan Kaya
On 6/19/2018 11:02 PM, Timur Tabi wrote: > On 6/19/18 9:14 PM, Sinan Kaya wrote: >> +    if (!(cap & PCI_EXP_DEVCAP2_E2ETLP)) >> +    return; >> + >> +    dev->eetlp_prefix = 1; > > How about: > > if (cap & PCI_EXP_DEVCAP2_E2ETLP) >     dev->eetlp_prefix = 1; > Both works. I'll

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-19 Thread Timur Tabi
On 6/19/18 9:14 PM, Sinan Kaya wrote: + if (!(cap & PCI_EXP_DEVCAP2_E2ETLP)) + return; + + dev->eetlp_prefix = 1; How about: if (cap & PCI_EXP_DEVCAP2_E2ETLP) dev->eetlp_prefix = 1; -- Qualcomm Datacenter Technologies, Inc. as an affiliate of

Re: [PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-19 Thread Timur Tabi
On 6/19/18 9:14 PM, Sinan Kaya wrote: + if (!(cap & PCI_EXP_DEVCAP2_E2ETLP)) + return; + + dev->eetlp_prefix = 1; How about: if (cap & PCI_EXP_DEVCAP2_E2ETLP) dev->eetlp_prefix = 1; -- Qualcomm Datacenter Technologies, Inc. as an affiliate of

[PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-19 Thread Sinan Kaya
A PCIe endpoint carries the process address space identifier (PASID) in the TLP prefix as part of the memory read/write transaction. The address information in the TLP is relevant only for a given PASID context. An IOMMU takes PASID value and the address information from the TLP to look up the

[PATCH V2] PCI: Enable PASID when End-to-End TLP is supported by all bridges

2018-06-19 Thread Sinan Kaya
A PCIe endpoint carries the process address space identifier (PASID) in the TLP prefix as part of the memory read/write transaction. The address information in the TLP is relevant only for a given PASID context. An IOMMU takes PASID value and the address information from the TLP to look up the