Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-28 Thread Stefan Wahren
Hi, Am 28.01.2015 um 17:10 schrieb Zhi Li: > On Wed, Jan 28, 2015 at 9:52 AM, Stefan Wahren wrote: >> Hi, >> >> Am 28.01.2015 um 04:36 schrieb Zhi Li: >>> On Tue, Jan 27, 2015 at 7:51 PM, Mike Turquette >>> wrote: Quoting Marek Vasut (2015-01-21 15:39:01) > On Wednesday, January 21, 20

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-28 Thread Fabio Estevam
Hi Stefan, On Sun, Dec 28, 2014 at 8:26 AM, Stefan Wahren wrote: > According to i.MX23 and i.MX28 reference manual the fractional > clock control registers must be addressed by byte instructions. > > This patch fixes the erroneous 32-bit access to these registers > and extends the comment in the

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-28 Thread Zhi Li
On Wed, Jan 28, 2015 at 10:40 AM, Stefan Wahren wrote: > The clk init for the i.MX28 in the kernel tries to the set > IO0FRAC and IO1FRAC at once. So this patch fix this problem. Okay, I am fine. I suggest add comment about only change one FRAC once. -- To unsubscribe from this list: send the li

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-28 Thread Zhi Li
On Wed, Jan 28, 2015 at 9:52 AM, Stefan Wahren wrote: > Hi, > > Am 28.01.2015 um 04:36 schrieb Zhi Li: >> On Tue, Jan 27, 2015 at 7:51 PM, Mike Turquette >> wrote: >>> Quoting Marek Vasut (2015-01-21 15:39:01) On Wednesday, January 21, 2015 at 05:16:03 PM, Zhi Li wrote: > On Sun, Dec 28

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-28 Thread Stefan Wahren
Hi, Am 28.01.2015 um 04:36 schrieb Zhi Li: > On Tue, Jan 27, 2015 at 7:51 PM, Mike Turquette wrote: >> Quoting Marek Vasut (2015-01-21 15:39:01) >>> On Wednesday, January 21, 2015 at 05:16:03 PM, Zhi Li wrote: On Sun, Dec 28, 2014 at 4:26 AM, Stefan Wahren wrote: > According to i.

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-27 Thread Zhi Li
On Tue, Jan 27, 2015 at 7:51 PM, Mike Turquette wrote: > Quoting Marek Vasut (2015-01-21 15:39:01) >> On Wednesday, January 21, 2015 at 05:16:03 PM, Zhi Li wrote: >> > On Sun, Dec 28, 2014 at 4:26 AM, Stefan Wahren >> > wrote: >> > > According to i.MX23 and i.MX28 reference manual the fractional

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-27 Thread Mike Turquette
Quoting Marek Vasut (2015-01-21 15:39:01) > On Wednesday, January 21, 2015 at 05:16:03 PM, Zhi Li wrote: > > On Sun, Dec 28, 2014 at 4:26 AM, Stefan Wahren > > wrote: > > > According to i.MX23 and i.MX28 reference manual the fractional > > > clock control registers must be addressed by byte instr

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-21 Thread Marek Vasut
On Wednesday, January 21, 2015 at 05:16:03 PM, Zhi Li wrote: > On Sun, Dec 28, 2014 at 4:26 AM, Stefan Wahren wrote: > > According to i.MX23 and i.MX28 reference manual the fractional > > clock control registers must be addressed by byte instructions. > > I don't think mx23 and mx28 have such lim

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-21 Thread Zhi Li
On Sun, Dec 28, 2014 at 4:26 AM, Stefan Wahren wrote: > According to i.MX23 and i.MX28 reference manual the fractional > clock control registers must be addressed by byte instructions. > I don't think mx23 and mx28 have such limitation. I will double check with IC team about this. RTL is generate

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-20 Thread Stefan Wahren
Hi, > Marek Vasut hat am 28. Dezember 2014 um 19:30 geschrieben: > > > On Sunday, December 28, 2014 at 11:26:42 AM, Stefan Wahren wrote: > > According to i.MX23 and i.MX28 reference manual the fractional > > clock control registers must be addressed by byte instructions. > > > > This patch fixes

Re: [PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-28 Thread Marek Vasut
On Sunday, December 28, 2014 at 11:26:42 AM, Stefan Wahren wrote: > According to i.MX23 and i.MX28 reference manual the fractional > clock control registers must be addressed by byte instructions. > > This patch fixes the erroneous 32-bit access to these registers > and extends the comment in the

[PATCH V2] clk: mxs: Fix invalid 32-bit access to frac registers

2014-12-28 Thread Stefan Wahren
According to i.MX23 and i.MX28 reference manual the fractional clock control registers must be addressed by byte instructions. This patch fixes the erroneous 32-bit access to these registers and extends the comment in the init functions. Btw the imx23 init now uses a R-M-W sequence just like imx2