Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On 22-07-16, 23:11, Rafael J. Wysocki wrote: > No, they aren't deprecated, not even sort of. > > Of course, stuff that can use frequency tables should implement > ->target_index, > because there's no valid reason for it not to do that. > > However, there are cases (and not legacy) where

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On 22-07-16, 23:11, Rafael J. Wysocki wrote: > No, they aren't deprecated, not even sort of. > > Of course, stuff that can use frequency tables should implement > ->target_index, > because there's no valid reason for it not to do that. > > However, there are cases (and not legacy) where

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Friday, July 22, 2016 08:13:27 AM Viresh Kumar wrote: > On 21-07-16, 17:34, Steve Muckle wrote: > > On Fri, Jul 22, 2016 at 02:18:54AM +0200, Rafael J. Wysocki wrote: > > > > My thinking was that one of these two would be preferable: > > > > > > > > - Forcing ->target() drivers to install a

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Friday, July 22, 2016 08:13:27 AM Viresh Kumar wrote: > On 21-07-16, 17:34, Steve Muckle wrote: > > On Fri, Jul 22, 2016 at 02:18:54AM +0200, Rafael J. Wysocki wrote: > > > > My thinking was that one of these two would be preferable: > > > > > > > > - Forcing ->target() drivers to install a

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On 21-07-16, 17:34, Steve Muckle wrote: > On Fri, Jul 22, 2016 at 02:18:54AM +0200, Rafael J. Wysocki wrote: > > > My thinking was that one of these two would be preferable: > > > > > > - Forcing ->target() drivers to install a ->resolve_freq callback, > > > enforcing this at cpufreq driver init

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On 21-07-16, 17:34, Steve Muckle wrote: > On Fri, Jul 22, 2016 at 02:18:54AM +0200, Rafael J. Wysocki wrote: > > > My thinking was that one of these two would be preferable: > > > > > > - Forcing ->target() drivers to install a ->resolve_freq callback, > > > enforcing this at cpufreq driver init

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 02:18:54AM +0200, Rafael J. Wysocki wrote: > > My thinking was that one of these two would be preferable: > > > > - Forcing ->target() drivers to install a ->resolve_freq callback, > > enforcing this at cpufreq driver init time. > > That would have been possible, but

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 02:18:54AM +0200, Rafael J. Wysocki wrote: > > My thinking was that one of these two would be preferable: > > > > - Forcing ->target() drivers to install a ->resolve_freq callback, > > enforcing this at cpufreq driver init time. > > That would have been possible, but

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 2:09 AM, Steve Muckle wrote: > On Fri, Jul 22, 2016 at 01:53:13AM +0200, Rafael J. Wysocki wrote: >> On Fri, Jul 22, 2016 at 1:45 AM, Steve Muckle >> wrote: >> > On Fri, Jul 22, 2016 at 01:32:00AM +0200, Rafael J. Wysocki

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 2:09 AM, Steve Muckle wrote: > On Fri, Jul 22, 2016 at 01:53:13AM +0200, Rafael J. Wysocki wrote: >> On Fri, Jul 22, 2016 at 1:45 AM, Steve Muckle >> wrote: >> > On Fri, Jul 22, 2016 at 01:32:00AM +0200, Rafael J. Wysocki wrote: >> >> On Fri, Jul 22, 2016 at 1:22 AM,

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 01:53:13AM +0200, Rafael J. Wysocki wrote: > On Fri, Jul 22, 2016 at 1:45 AM, Steve Muckle wrote: > > On Fri, Jul 22, 2016 at 01:32:00AM +0200, Rafael J. Wysocki wrote: > >> On Fri, Jul 22, 2016 at 1:22 AM, Steve Muckle >

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 01:53:13AM +0200, Rafael J. Wysocki wrote: > On Fri, Jul 22, 2016 at 1:45 AM, Steve Muckle wrote: > > On Fri, Jul 22, 2016 at 01:32:00AM +0200, Rafael J. Wysocki wrote: > >> On Fri, Jul 22, 2016 at 1:22 AM, Steve Muckle > >> wrote: > >> > On Fri, Jul 22, 2016 at

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 1:45 AM, Steve Muckle wrote: > On Fri, Jul 22, 2016 at 01:32:00AM +0200, Rafael J. Wysocki wrote: >> On Fri, Jul 22, 2016 at 1:22 AM, Steve Muckle >> wrote: >> > On Fri, Jul 22, 2016 at 01:22:22AM +0200, Rafael J. Wysocki

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 1:45 AM, Steve Muckle wrote: > On Fri, Jul 22, 2016 at 01:32:00AM +0200, Rafael J. Wysocki wrote: >> On Fri, Jul 22, 2016 at 1:22 AM, Steve Muckle >> wrote: >> > On Fri, Jul 22, 2016 at 01:22:22AM +0200, Rafael J. Wysocki wrote: >> >> OK, applied. >> > >> > FWIW I do

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 01:32:00AM +0200, Rafael J. Wysocki wrote: > On Fri, Jul 22, 2016 at 1:22 AM, Steve Muckle wrote: > > On Fri, Jul 22, 2016 at 01:22:22AM +0200, Rafael J. Wysocki wrote: > >> OK, applied. > > > > FWIW I do have a concern on this patch, I think it

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 01:32:00AM +0200, Rafael J. Wysocki wrote: > On Fri, Jul 22, 2016 at 1:22 AM, Steve Muckle wrote: > > On Fri, Jul 22, 2016 at 01:22:22AM +0200, Rafael J. Wysocki wrote: > >> OK, applied. > > > > FWIW I do have a concern on this patch, I think it adds unnecessary > >

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 1:22 AM, Steve Muckle wrote: > On Fri, Jul 22, 2016 at 01:22:22AM +0200, Rafael J. Wysocki wrote: >> OK, applied. > > FWIW I do have a concern on this patch, I think it adds unnecessary > overhead. It isn't unnecessary. It prevents an otherwise

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 1:22 AM, Steve Muckle wrote: > On Fri, Jul 22, 2016 at 01:22:22AM +0200, Rafael J. Wysocki wrote: >> OK, applied. > > FWIW I do have a concern on this patch, I think it adds unnecessary > overhead. It isn't unnecessary. It prevents an otherwise possible kernel crash from

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 01:22:22AM +0200, Rafael J. Wysocki wrote: > OK, applied. FWIW I do have a concern on this patch, I think it adds unnecessary overhead.

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Fri, Jul 22, 2016 at 01:22:22AM +0200, Rafael J. Wysocki wrote: > OK, applied. FWIW I do have a concern on this patch, I think it adds unnecessary overhead.

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Thursday, July 21, 2016 02:39:26 PM Viresh Kumar wrote: > The handlers provided by cpufreq core are sufficient for resolving the > frequency for drivers providing ->target_index(), as the core already > has the frequency table and so ->resolve_freq() isn't required for such > platforms. > >

Re: [PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

On Thursday, July 21, 2016 02:39:26 PM Viresh Kumar wrote: > The handlers provided by cpufreq core are sufficient for resolving the > frequency for drivers providing ->target_index(), as the core already > has the frequency table and so ->resolve_freq() isn't required for such > platforms. > >

[PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

The handlers provided by cpufreq core are sufficient for resolving the frequency for drivers providing ->target_index(), as the core already has the frequency table and so ->resolve_freq() isn't required for such platforms. This patch disallows drivers with ->target_index() callback to use the

[PATCH V2] cpufreq: Disallow ->resolve_freq() for drivers providing ->target_index()

The handlers provided by cpufreq core are sufficient for resolving the frequency for drivers providing ->target_index(), as the core already has the frequency table and so ->resolve_freq() isn't required for such platforms. This patch disallows drivers with ->target_index() callback to use the