Re: [PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

2016-05-26 Thread Richard Weinberger
Am 26.05.2016 um 16:28 schrieb Salah Triki: > Code is more readable when using kmem_cache_zalloc instead of > kmem_cache_alloc/memset. I don't fully agree. You also have ignored my other comment on this patch. Please note that the path you are patching is a hot path. Thanks, //richard

Re: [PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

2016-05-26 Thread Richard Weinberger
Am 26.05.2016 um 16:28 schrieb Salah Triki: > Code is more readable when using kmem_cache_zalloc instead of > kmem_cache_alloc/memset. I don't fully agree. You also have ignored my other comment on this patch. Please note that the path you are patching is a hot path. Thanks, //richard

[PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

2016-05-26 Thread Salah Triki
Code is more readable when using kmem_cache_zalloc instead of kmem_cache_alloc/memset. Signed-off-by: Salah Triki --- fs/ubifs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 7034995..f509200 100644

[PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

2016-05-26 Thread Salah Triki
Code is more readable when using kmem_cache_zalloc instead of kmem_cache_alloc/memset. Signed-off-by: Salah Triki --- fs/ubifs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 7034995..f509200 100644 --- a/fs/ubifs/super.c