Re: [PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-02-04 Thread Hans Holmberg
On Mon, Feb 4, 2019 at 9:14 AM Javier González wrote: > > > > On 31 Jan 2019, at 21.10, Hans Holmberg wrote: > > > > On Thu, Jan 31, 2019 at 5:33 PM Javier González wrote: > >>> On 31 Jan 2019, at 11.41, Hans Holmberg wrote: > >>> > >>> Hi Javier! > >>> > >>> How did you test this? I'm trying t

Re: [PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-02-04 Thread Javier González
> On 31 Jan 2019, at 21.10, Hans Holmberg wrote: > > On Thu, Jan 31, 2019 at 5:33 PM Javier González wrote: >>> On 31 Jan 2019, at 11.41, Hans Holmberg wrote: >>> >>> Hi Javier! >>> >>> How did you test this? I'm trying to add a test case to our testing >>> framework. >>> >>> This is what

Re: [PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-01-31 Thread Hans Holmberg
On Thu, Jan 31, 2019 at 5:33 PM Javier González wrote: > > > > > On 31 Jan 2019, at 11.41, Hans Holmberg wrote: > > > > Hi Javier! > > > > How did you test this? I'm trying to add a test case to our testing > > framework. > > > > This is what i ran in qemu, and I got a hang (with this version of

Re: [PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-01-31 Thread Javier González
> On 31 Jan 2019, at 11.41, Hans Holmberg wrote: > > Hi Javier! > > How did you test this? I'm trying to add a test case to our testing framework. > > This is what i ran in qemu, and I got a hang (with this version of the patch) > > nvme lnvm create -d nvme0n1 -t pblk -n pblk0 -f -b 0 -e 0

Re: [PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-01-31 Thread Hans Holmberg
Hi Javier! How did you test this? I'm trying to add a test case to our testing framework. This is what i ran in qemu, and I got a hang (with this version of the patch) nvme lnvm create -d nvme0n1 -t pblk -n pblk0 -f -b 0 -e 0 kernel log: [ 116.381799] pblk pblk0: luns:1, lines:280, secs:212736

Re: [PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-01-30 Thread Matias Bjørling
On 1/30/19 11:26 AM, Javier González wrote: In order to respect mw_cuinits, pblk's write buffer maintains a backpointer to protect data not yet persisted; when writing to the write buffer, this backpointer defines a threshold that pblk's rate-limiter enforces. On small PU configurations, the fol

[PATCH V2] lightnvm: pblk: prevent stall due to wb threshold

2019-01-30 Thread Javier González
In order to respect mw_cuinits, pblk's write buffer maintains a backpointer to protect data not yet persisted; when writing to the write buffer, this backpointer defines a threshold that pblk's rate-limiter enforces. On small PU configurations, the following scenarios might take place: (i) the thr