RE: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

2017-09-25 Thread Shivasharan Srikanteshwara
@oracle.com; > PDL,MEGARAIDLINUX; linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org; ch...@redhat.com; yiz...@redhat.com; > catalin.mari...@arm.com > Subject: Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion > > Oh, I missed log_to_span. Well, in that case

Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

2017-09-18 Thread Christoph Hellwig
Oh, I missed log_to_span. Well, in that case log_to_span is _the_ candidate for moving into a separate allocation. And in fact you're probably better off by using a sensible data structure for it, e.g. a radix tree.

RE: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

2017-09-18 Thread Shivasharan Srikanteshwara
om; > martin.peter...@oracle.com; megaraidlinux@broadcom.com; linux- > s...@vger.kernel.org; linux-kernel@vger.kernel.org; ch...@redhat.com; > yiz...@redhat.com; catalin.mari...@arm.com > Subject: Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion > > I think t

Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

2017-09-15 Thread Christoph Hellwig
I think the megaraid fusion code has a deeper problem here. Instead of playing weird games with get_free_pages and vmalloc the structure just needs to shrink by moving all the arrays of MAX_MSIX_QUEUES_FUSION size into a separate allocation for each, and then we have normall, small kmalloc allocat

Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

2017-09-15 Thread Bart Van Assche
On Fri, 2017-09-15 at 13:21 +0800, shuw...@redhat.com wrote: > @@ -4548,9 +4556,11 @@ megasas_free_fusion_context(struct megasas_instance > *instance) > > if (is_vmalloc_addr(fusion)) > vfree(fusion); > - else > + else { > +

Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

2017-09-15 Thread Catalin Marinas
On Fri, Sep 15, 2017 at 01:21:52PM +0800, shuw...@redhat.com wrote: > From: Shu Wang > > Kmemleak reports about a thousand false positives for fusion-> > cmd_list[]. Root casue is the cmd_list objects are allocated from > slab allocator, and stored its pointer in object allocated by page > alloca

[PATCH V2] megaraid: kmemleak: Track page allocation for fusion

2017-09-14 Thread shuwang
From: Shu Wang Kmemleak reports about a thousand false positives for fusion-> cmd_list[]. Root casue is the cmd_list objects are allocated from slab allocator, and stored its pointer in object allocated by page allocator. The fix will tell kmemleak to track and scan fusion object. V2: Add commen