Re: [PATCH V2] mm:memory hot-add: memory can not been added to movable zone

2015-08-25 Thread Changsheng Liu
First, thanks very much for your review, I will update codes according to your suggestion On 2015/8/25 21:12, Yasuaki Ishimatsu wrote: On Thu, 20 Aug 2015 03:28:05 -0400 Changsheng Liu wrote: From: Changsheng Liu When memory is hot added, should_add_memory_movable() always returns 0 becaus

Re: [PATCH V2] mm:memory hot-add: memory can not been added to movable zone

2015-08-25 Thread Yasuaki Ishimatsu
On Thu, 20 Aug 2015 03:28:05 -0400 Changsheng Liu wrote: > From: Changsheng Liu > > When memory is hot added, should_add_memory_movable() always returns 0 > because the movable zone is empty, so the memory that was hot added will > add to the normal zone even if we want to remove the memory. >

Re: [PATCH V2] mm:memory hot-add: memory can not been added to movable zone

2015-08-24 Thread Vlastimil Babka
On 08/21/2015 04:00 AM, Changsheng Liu wrote: On 08/20/201515:41, Vlastimil Babka wrote: On 08/20/2015 09:28 AM, Changsheng Liu wrote: From: Changsheng Liu When memory is hot added, should_add_memory_movable() always returns 0 because the movable zone is empty, so the memory that was hot add

Re: [PATCH V2] mm:memory hot-add: memory can not been added to movable zone

2015-08-20 Thread Changsheng Liu
On 08/20/201515:41, Vlastimil Babka wrote: On 08/20/2015 09:28 AM, Changsheng Liu wrote: From: Changsheng Liu When memory is hot added, should_add_memory_movable() always returns 0 because the movable zone is empty, so the memory that was hot added will add to the normal zone even if we want

Re: [PATCH V2] mm:memory hot-add: memory can not been added to movable zone

2015-08-20 Thread Vlastimil Babka
On 08/20/2015 09:41 AM, Vlastimil Babka wrote: want to hot-remove and don't want movable zones (which limit what kind of allocations are possible), is there a way to prevent memory being movable after your patch? Oh, and not enabling CONFIG_MOVABLE_NODE is not sufficient here IMHO, as users mi

Re: [PATCH V2] mm:memory hot-add: memory can not been added to movable zone

2015-08-20 Thread Vlastimil Babka
On 08/20/2015 09:28 AM, Changsheng Liu wrote: From: Changsheng Liu When memory is hot added, should_add_memory_movable() always returns 0 because the movable zone is empty, so the memory that was hot added will add to the normal zone even if we want to remove the memory. I'm not expert on mem

[PATCH V2] mm:memory hot-add: memory can not been added to movable zone

2015-08-20 Thread Changsheng Liu
From: Changsheng Liu When memory is hot added, should_add_memory_movable() always returns 0 because the movable zone is empty, so the memory that was hot added will add to the normal zone even if we want to remove the memory. So we change should_add_memory_movable(): if the user config CONFIG_MO