Re: [PATCH V2] nvme-pci: move nvme_kill_queues to nvme_remove_dead_ctrl

On Wed, Jun 20, 2018 at 01:42:22PM +0800, Jianchao Wang wrote: > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index fc33804..73a97fc 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -2289,6 +2289,7 @@ static void nvme_remove_dead_ctrl(struct nvme_dev

Re: [PATCH V2] nvme-pci: move nvme_kill_queues to nvme_remove_dead_ctrl

On Wed, Jun 20, 2018 at 01:42:22PM +0800, Jianchao Wang wrote: > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index fc33804..73a97fc 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -2289,6 +2289,7 @@ static void nvme_remove_dead_ctrl(struct nvme_dev

[PATCH V2] nvme-pci: move nvme_kill_queues to nvme_remove_dead_ctrl

There is race between nvme_remove and nvme_reset_work that can lead to io hang. nvme_removenvme_reset_work -> nvme_remove_dead_ctrl -> nvme_dev_disable -> quiesce request_queue

[PATCH V2] nvme-pci: move nvme_kill_queues to nvme_remove_dead_ctrl

There is race between nvme_remove and nvme_reset_work that can lead to io hang. nvme_removenvme_reset_work -> nvme_remove_dead_ctrl -> nvme_dev_disable -> quiesce request_queue