Re: [PATCH V2] of: fix clang -Wunsequenced for be32_to_cpu()

2019-05-01 Thread Rob Herring
On Wed, May 1, 2019 at 1:13 PM Nick Desaulniers wrote: > > On Tue, Apr 30, 2019 at 9:29 AM Nick Desaulniers > wrote: > > > > On Tue, Apr 30, 2019 at 9:28 AM Nick Desaulniers > > wrote: > > > Thanks for the patch. > > > Reported-by: Nick Desaulniers > > > Link: https://github.com/ClangBuiltLinux

Re: [PATCH V2] of: fix clang -Wunsequenced for be32_to_cpu()

2019-05-01 Thread Nick Desaulniers
On Tue, Apr 30, 2019 at 9:29 AM Nick Desaulniers wrote: > > On Tue, Apr 30, 2019 at 9:28 AM Nick Desaulniers > wrote: > > Thanks for the patch. > > Reported-by: Nick Desaulniers > > Link: https://github.com/ClangBuiltLinux/linux/issues/460 > > Suggested-by: David Laight > > sent too soon... > R

Re: [PATCH V2] of: fix clang -Wunsequenced for be32_to_cpu()

2019-04-30 Thread Nick Desaulniers
On Tue, Apr 30, 2019 at 9:28 AM Nick Desaulniers wrote: > > On Tue, Apr 30, 2019 at 7:58 AM Phong Tran wrote: > > > > Now, make the loop explicit to avoid clang warning. > > > > ./include/linux/of.h:238:37: warning: multiple unsequenced modifications > > to 'cell' [-Wunsequenced] > >

Re: [PATCH V2] of: fix clang -Wunsequenced for be32_to_cpu()

2019-04-30 Thread Nick Desaulniers
On Tue, Apr 30, 2019 at 7:58 AM Phong Tran wrote: > > Now, make the loop explicit to avoid clang warning. > > ./include/linux/of.h:238:37: warning: multiple unsequenced modifications > to 'cell' [-Wunsequenced] > r = (r << 32) | be32_to_cpu(*(cell++)); >

[PATCH V2] of: fix clang -Wunsequenced for be32_to_cpu()

2019-04-30 Thread Phong Tran
Now, make the loop explicit to avoid clang warning. ./include/linux/of.h:238:37: warning: multiple unsequenced modifications to 'cell' [-Wunsequenced] r = (r << 32) | be32_to_cpu(*(cell++)); ^~ ./include/linux/byteorder/generic.h:95