Re: [PATCH V2] ovl: Fix dereferencing possible ERR_PTR()

2019-09-12 Thread Amir Goldstein
On Thu, Sep 12, 2019 at 12:28 PM Miklos Szeredi wrote: > > On Thu, Sep 12, 2019 at 8:02 AM Amir Goldstein wrote: > > > > On Thu, Sep 12, 2019 at 8:24 AM Ding Xiang > > wrote: > > > > > > if ovl_encode_real_fh() fails, no memory was allocated > > > and the error in the error-valued pointer

Re: [PATCH V2] ovl: Fix dereferencing possible ERR_PTR()

2019-09-12 Thread Miklos Szeredi
On Thu, Sep 12, 2019 at 8:02 AM Amir Goldstein wrote: > > On Thu, Sep 12, 2019 at 8:24 AM Ding Xiang > wrote: > > > > if ovl_encode_real_fh() fails, no memory was allocated > > and the error in the error-valued pointer should be returned. > > > > V1->V2: fix SHA1 length problem > > > > Fixes:

Re: [PATCH V2] ovl: Fix dereferencing possible ERR_PTR()

2019-09-12 Thread Amir Goldstein
On Thu, Sep 12, 2019 at 8:24 AM Ding Xiang wrote: > > if ovl_encode_real_fh() fails, no memory was allocated > and the error in the error-valued pointer should be returned. > > V1->V2: fix SHA1 length problem > > Fixes: 9b6faee07470 ("ovl: check ERR_PTR() return value from ovl_encode_fh()") >

[PATCH V2] ovl: Fix dereferencing possible ERR_PTR()

2019-09-11 Thread Ding Xiang
if ovl_encode_real_fh() fails, no memory was allocated and the error in the error-valued pointer should be returned. V1->V2: fix SHA1 length problem Fixes: 9b6faee07470 ("ovl: check ERR_PTR() return value from ovl_encode_fh()") Signed-off-by: Ding Xiang --- fs/overlayfs/export.c | 2 +- 1 file