Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Paul E. McKenney
On Mon, May 11, 2015 at 09:11:59AM -0700, Josh Triplett wrote: > On Mon, May 11, 2015 at 05:46:12PM +0200, Nicholas Mc Guire wrote: > > rcu_cpu_has_callbacks() is declared int but is actually returning bool > > and as the function description states " * Return true if the specified > > CPU has

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
On Mon, 11 May 2015, Steven Rostedt wrote: > On Mon, 11 May 2015 17:45:10 +0200 > Nicholas Mc Guire wrote: > > - sorry for being so complicated. > > Nah, we are the ones being complicated. > > > had been putting config info below in all patches - and in git log I do > > not see that

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 05:46:12PM +0200, Nicholas Mc Guire wrote: > rcu_cpu_has_callbacks() is declared int but is actually returning bool > and as the function description states " * Return true if the specified > CPU has any callback", this probably should be a bool. All (3) > call-sites

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Steven Rostedt
On Mon, 11 May 2015 17:45:10 +0200 Nicholas Mc Guire wrote: - sorry for being so complicated. Nah, we are the ones being complicated. > had been putting config info below in all patches - and in git log I do > not see that information being included - anyway will move it up and > resend in a

[PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
rcu_cpu_has_callbacks() is declared int but is actually returning bool and as the function description states " * Return true if the specified CPU has any callback", this probably should be a bool. All (3) call-sites currently treat it as bool. Type-checking coccinelle spatches are being

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
On Mon, 11 May 2015, Josh Triplett wrote: > On Mon, May 11, 2015 at 11:28:30AM -0400, Steven Rostedt wrote: > > On Mon, 11 May 2015 17:10:59 +0200 > > Nicholas Mc Guire wrote: > > > > > rcu_cpu_has_callbacks() is declared int but is actually returning bool and > > > and as the function

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:28:30AM -0400, Steven Rostedt wrote: > On Mon, 11 May 2015 17:10:59 +0200 > Nicholas Mc Guire wrote: > > > rcu_cpu_has_callbacks() is declared int but is actually returning bool and > > and as the function description states " * Return true if the specified > > CPU

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Steven Rostedt
On Mon, 11 May 2015 17:10:59 +0200 Nicholas Mc Guire wrote: > rcu_cpu_has_callbacks() is declared int but is actually returning bool and > and as the function description states " * Return true if the specified > CPU has any callback", this probably should be a bool. All (3) > call-sites

[PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
rcu_cpu_has_callbacks() is declared int but is actually returning bool and and as the function description states " * Return true if the specified CPU has any callback", this probably should be a bool. All (3) call-sites currently treat it as bool so the declaration. Signed-off-by:

[PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
rcu_cpu_has_callbacks() is declared int but is actually returning bool and and as the function description states * Return true if the specified CPU has any callback, this probably should be a bool. All (3) call-sites currently treat it as bool so the declaration. Signed-off-by: Nicholas

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Steven Rostedt
On Mon, 11 May 2015 17:10:59 +0200 Nicholas Mc Guire hof...@osadl.org wrote: rcu_cpu_has_callbacks() is declared int but is actually returning bool and and as the function description states * Return true if the specified CPU has any callback, this probably should be a bool. All (3)

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:28:30AM -0400, Steven Rostedt wrote: On Mon, 11 May 2015 17:10:59 +0200 Nicholas Mc Guire hof...@osadl.org wrote: rcu_cpu_has_callbacks() is declared int but is actually returning bool and and as the function description states * Return true if the specified

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
On Mon, 11 May 2015, Josh Triplett wrote: On Mon, May 11, 2015 at 11:28:30AM -0400, Steven Rostedt wrote: On Mon, 11 May 2015 17:10:59 +0200 Nicholas Mc Guire hof...@osadl.org wrote: rcu_cpu_has_callbacks() is declared int but is actually returning bool and and as the function

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
On Mon, 11 May 2015, Steven Rostedt wrote: On Mon, 11 May 2015 17:45:10 +0200 Nicholas Mc Guire der.h...@hofr.at wrote: - sorry for being so complicated. Nah, we are the ones being complicated. had been putting config info below in all patches - and in git log I do not see that

[PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
rcu_cpu_has_callbacks() is declared int but is actually returning bool and as the function description states * Return true if the specified CPU has any callback, this probably should be a bool. All (3) call-sites currently treat it as bool. Type-checking coccinelle spatches are being used

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 05:46:12PM +0200, Nicholas Mc Guire wrote: rcu_cpu_has_callbacks() is declared int but is actually returning bool and as the function description states * Return true if the specified CPU has any callback, this probably should be a bool. All (3) call-sites

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Steven Rostedt
On Mon, 11 May 2015 17:45:10 +0200 Nicholas Mc Guire der.h...@hofr.at wrote: - sorry for being so complicated. Nah, we are the ones being complicated. had been putting config info below in all patches - and in git log I do not see that information being included - anyway will move it up and

Re: [PATCH V2] rcu: change function declaration to bool

2015-05-11 Thread Paul E. McKenney
On Mon, May 11, 2015 at 09:11:59AM -0700, Josh Triplett wrote: On Mon, May 11, 2015 at 05:46:12PM +0200, Nicholas Mc Guire wrote: rcu_cpu_has_callbacks() is declared int but is actually returning bool and as the function description states * Return true if the specified CPU has any