Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-11 Thread Maciej W. Rozycki
On Mon, 1 Feb 2021, Thomas Gleixner wrote: > >> While it cures the problem on the reporters machine it breaks machines > >> with Intel chipsets which use bit 0-5 of the D register. So check only > >> for bit 6 being 0 which is the case on these Intel machines as well. > > > > This looks fine, but

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-03 Thread Mickaël Salaün
FWIW, it's still OK for me. Tested-by: Mickaël Salaün On 01/02/2021 20:24, Thomas Gleixner wrote: > The recent change to validate the RTC turned out to be overly tight. > > While it cures the problem on the reporters machine it breaks machines > with Intel chipsets which use bit 0-5 of the D

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Len Brown
Thanks for the update, Thomas. V1 prevented rc6 automated suspend/resume testing on all 13 of my local machines. V2 applied, and they are back in business. tested-by: Len Brown On Mon, Feb 1, 2021 at 2:25 PM Thomas Gleixner wrote: > > The recent change to validate the RTC turned out to be

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Dirk Gouders
Thomas Gleixner writes: > The recent change to validate the RTC turned out to be overly tight. > > While it cures the problem on the reporters machine it breaks machines > with Intel chipsets which use bit 0-5 of the D register. So check only > for bit 6 being 0 which is the case on these Intel

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Borislav Petkov
On Mon, Feb 01, 2021 at 08:24:17PM +0100, Thomas Gleixner wrote: > The recent change to validate the RTC turned out to be overly tight. > > While it cures the problem on the reporters machine it breaks machines > with Intel chipsets which use bit 0-5 of the D register. So check only > for bit 6

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Thomas Gleixner
On Mon, Feb 01 2021 at 11:32, Linus Torvalds wrote: > On Mon, Feb 1, 2021 at 11:24 AM Thomas Gleixner wrote: >> >> While it cures the problem on the reporters machine it breaks machines >> with Intel chipsets which use bit 0-5 of the D register. So check only >> for bit 6 being 0 which is the

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Alexandre Belloni
On 01/02/2021 20:24:17+0100, Thomas Gleixner wrote: > The recent change to validate the RTC turned out to be overly tight. > > While it cures the problem on the reporters machine it breaks machines > with Intel chipsets which use bit 0-5 of the D register. So check only > for bit 6 being 0 which

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Linus Torvalds
On Mon, Feb 1, 2021 at 11:24 AM Thomas Gleixner wrote: > > While it cures the problem on the reporters machine it breaks machines > with Intel chipsets which use bit 0-5 of the D register. So check only > for bit 6 being 0 which is the case on these Intel machines as well. This looks fine, but

[PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Thomas Gleixner
The recent change to validate the RTC turned out to be overly tight. While it cures the problem on the reporters machine it breaks machines with Intel chipsets which use bit 0-5 of the D register. So check only for bit 6 being 0 which is the case on these Intel machines as well. Fixes: