On 18/12/20 12:57 am, Bean Huo wrote:
> On Thu, 2020-12-17 at 11:49 +0200, Adrian Hunter wrote:
>>>
>>> The purpose of patch is acceptable, but I don't know why you choose
>>> using ufshcd_core_* here.
>>
>> Do you mean you would like a different function name? 'ufshcd_init'
>> is used
>> already
On Thu, 2020-12-17 at 11:49 +0200, Adrian Hunter wrote:
> >
> > The purpose of patch is acceptable, but I don't know why you choose
> > using ufshcd_core_* here.
>
> Do you mean you would like a different function name? 'ufshcd_init'
> is used
> already. The module is called ufshcd-core, so uf
Please add my reviewed-by once you fix that.
Thanks,
Avri
> However I do see a problem. When builtin, initcalls are ordered according
> to link order, but the Makefile does not have ufshcd-core at the top i.e.
>
> $ cat drivers/scsi/ufs/Makefile
> # SPDX-License-Identifier: GPL-2.0
> # UFSHCD ma
On 16/12/20 10:16 pm, Bean Huo wrote:
> On Wed, 2020-12-16 at 20:51 +0200, Adrian Hunter wrote:
>> ufshcd_variant_hba_exit(hba);
>> ufshcd_setup_vreg(hba, false);
>> ufshcd_suspend_clkscaling(hba);
>> @@ -9436,6 +9441,20 @@ int ufshcd_init(struct ufs_
On Wed, 2020-12-16 at 20:51 +0200, Adrian Hunter wrote:
> ufshcd_variant_hba_exit(hba);
> ufshcd_setup_vreg(hba, false);
> ufshcd_suspend_clkscaling(hba);
> @@ -9436,6 +9441,20 @@ int ufshcd_init(struct ufs_hba *hba, void
> __iomem *mmio_base, unsigne
People testing have a need to know how many errors might be occurring
over time. Add error counters and expose them via debugfs.
Signed-off-by: Adrian Hunter
---
Changes in V2:
Add missing '#include "ufs-debugfs.h"' in ufs-debugfs.c
Reported-by: kernel test robot
drivers/scs
6 matches
Mail list logo
