Re: [PATCH V2] tty: fix memleak in alloc_pid

2014-04-14 Thread One Thousand Gnomes
> move spin_unlock(sighand->siglock) after get_current_tty() can avoid > the race and fix the memleak. We already take tty_ctrl_lock inside sighand->siglock so this all appears safe and correct to me. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH V2] tty: fix memleak in alloc_pid

2014-04-14 Thread Chen Tingjie
There is memleak in alloc_pid: -- unreferenced object 0xd3453a80 (size 64): comm "adbd", pid 1730, jiffies 66363 (age 6586.950s) hex dump (first 32 bytes): 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 40 c2 f6 d5 00 d3 25 c1 5