Re: [PATCH V2] x86/entry/64: De-Xen-ify our NMI code further

2021-01-25 Thread Steven Rostedt
On Mon, 25 Jan 2021 09:51:45 -0800 Andy Lutomirski wrote: > > The problem I see with this is that exc_nmi is called with the thread > > stack, if it were to take an exception, NMIs would be enabled allowing for > > a nested NMI to run. From what I can tell, I don't see anything stopping > > that

Re: [PATCH V2] x86/entry/64: De-Xen-ify our NMI code further

2021-01-25 Thread Andy Lutomirski
> On Jan 25, 2021, at 9:39 AM, Steven Rostedt wrote: > > On Mon, 25 Jan 2021 15:45:06 +0800 > Lai Jiangshan wrote: > >> From: Lai Jiangshan >> >> The commit 929bacec21478("x86/entry/64: De-Xen-ify our NMI code") simplified >> the NMI code by changing paravirt code into native code and

Re: [PATCH V2] x86/entry/64: De-Xen-ify our NMI code further

2021-01-25 Thread Steven Rostedt
On Mon, 25 Jan 2021 12:38:59 -0500 Steven Rostedt wrote: > On triggering an NMI from user space, I see the switch to the thread stack > is done, and "exc_nmi" is called. > > The problem I see with this is that exc_nmi is called with the thread > stack, if it were to take an exception, NMIs

Re: [PATCH V2] x86/entry/64: De-Xen-ify our NMI code further

2021-01-25 Thread Steven Rostedt
On Mon, 25 Jan 2021 15:45:06 +0800 Lai Jiangshan wrote: > From: Lai Jiangshan > > The commit 929bacec21478("x86/entry/64: De-Xen-ify our NMI code") simplified > the NMI code by changing paravirt code into native code and left a comment > about "inspecting RIP instead". But until now,

[PATCH V2] x86/entry/64: De-Xen-ify our NMI code further

2021-01-24 Thread Lai Jiangshan
From: Lai Jiangshan The commit 929bacec21478("x86/entry/64: De-Xen-ify our NMI code") simplified the NMI code by changing paravirt code into native code and left a comment about "inspecting RIP instead". But until now, "inspecting RIP instead" has not been made happened and this patch tries to