Re: [PATCH V2] x86/intel_rdt: Ensure usage of CPUs are locked while needed

2018-12-11 Thread Borislav Petkov
On Tue, Dec 11, 2018 at 12:51:12PM -0800, Reinette Chatre wrote: > I really appreciate your patience. That goes both ways. Thx. :-) > That subject line matches exactly the goal of this patch. Thank you very > much. Would you prefer that I send a new version with this subject line > or would you r

Re: [PATCH V2] x86/intel_rdt: Ensure usage of CPUs are locked while needed

2018-12-11 Thread Reinette Chatre
Hi Boris, On 12/11/2018 12:43 PM, Borislav Petkov wrote: > On Tue, Dec 11, 2018 at 11:02:08AM -0800, Reinette Chatre wrote: >> I just wanted to emphasize that it is not the schemata writing that >> needs to be protected, but instead the pseudo-locking code that runs >> after schemata programming t

Re: [PATCH V2] x86/intel_rdt: Ensure usage of CPUs are locked while needed

2018-12-11 Thread Borislav Petkov
On Tue, Dec 11, 2018 at 11:02:08AM -0800, Reinette Chatre wrote: > I just wanted to emphasize that it is not the schemata writing that > needs to be protected, but instead the pseudo-locking code that runs > after schemata programming that needs to run on a particular CPU. The > new patch subject c

Re: [PATCH V2] x86/intel_rdt: Ensure usage of CPUs are locked while needed

2018-12-11 Thread Reinette Chatre
Hi Boris, On 12/11/2018 10:50 AM, Borislav Petkov wrote: > On Tue, Dec 11, 2018 at 10:33:59AM -0800, Reinette Chatre wrote: >> I am not sure that this is an issue when updating a schemata in the >> general case. In the case when just CAT schemata (without >> pseudo-locking) is updated then the cpu

Re: [PATCH V2] x86/intel_rdt: Ensure usage of CPUs are locked while needed

2018-12-11 Thread Borislav Petkov
On Tue, Dec 11, 2018 at 10:33:59AM -0800, Reinette Chatre wrote: > I am not sure that this is an issue when updating a schemata in the > general case. In the case when just CAT schemata (without > pseudo-locking) is updated then the cpu mask associated with the cache > instance is indeed used to de

Re: [PATCH V2] x86/intel_rdt: Ensure usage of CPUs are locked while needed

2018-12-11 Thread Reinette Chatre
Hi Boris, On 12/11/2018 4:34 AM, Borislav Petkov wrote: > On Mon, Dec 10, 2018 at 01:21:54PM -0800, Reinette Chatre wrote: >> The user triggers the creation of a pseudo-locked region when writing >> the requested schemata to the schemata resctrl file. The pseudo-locking >> of a region is required

Re: [PATCH V2] x86/intel_rdt: Ensure usage of CPUs are locked while needed

2018-12-11 Thread Borislav Petkov
On Mon, Dec 10, 2018 at 01:21:54PM -0800, Reinette Chatre wrote: > The user triggers the creation of a pseudo-locked region when writing > the requested schemata to the schemata resctrl file. The pseudo-locking > of a region is required to be done on a CPU that is associated with the > cache on whi

[PATCH V2] x86/intel_rdt: Ensure usage of CPUs are locked while needed

2018-12-10 Thread Reinette Chatre
The user triggers the creation of a pseudo-locked region when writing the requested schemata to the schemata resctrl file. The pseudo-locking of a region is required to be done on a CPU that is associated with the cache on which the pseudo-locked region will reside. In order to run the locking code