Re: [PATCH V2] x86/numa: kernel stack corruption fix

2015-04-08 Thread Baoquan He
On 04/08/15 at 11:09am, Dave Young wrote: > On 04/08/15 at 10:41am, Xishi Qiu wrote: > > >> Hi Dave, > > >> > > >> I made a mistake, when numa is on, numa_meminfo is from SRAT, but it > > >> will be cut > > >> in numa_cleanup_meminfo(), so the bug is not related to numa on/off. > > >> Your commen

Re: [PATCH V2] x86/numa: kernel stack corruption fix

2015-04-07 Thread Dave Young
On 04/08/15 at 10:41am, Xishi Qiu wrote: > On 2015/4/8 10:18, Baoquan He wrote: > > > On 04/08/15 at 09:59am, Xishi Qiu wrote: > >> On 2015/4/8 9:46, Dave Young wrote: > >> > > > > - /* Mark all kernel nodes. */ > > + /* > > +* Mark all kernel nodes. > > +

Re: [PATCH V2] x86/numa: kernel stack corruption fix

2015-04-07 Thread Xishi Qiu
On 2015/4/8 10:18, Baoquan He wrote: > On 04/08/15 at 09:59am, Xishi Qiu wrote: >> On 2015/4/8 9:46, Dave Young wrote: >> > > - /* Mark all kernel nodes. */ > + /* > + * Mark all kernel nodes. > + * > + * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminf

Re: [PATCH V2] x86/numa: kernel stack corruption fix

2015-04-07 Thread Baoquan He
On 04/08/15 at 09:59am, Xishi Qiu wrote: > On 2015/4/8 9:46, Dave Young wrote: > > >>> > >>> - /* Mark all kernel nodes. */ > >>> + /* > >>> + * Mark all kernel nodes. > >>> + * > >>> + * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo > >> > >> Hi Dave, > >> > >> It should

Re: [PATCH V2] x86/numa: kernel stack corruption fix

2015-04-07 Thread Xishi Qiu
On 2015/4/8 9:46, Dave Young wrote: >>> >>> - /* Mark all kernel nodes. */ >>> + /* >>> +* Mark all kernel nodes. >>> +* >>> +* In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo >> >> Hi Dave, >> >> It should both set mem=xx and numa=off, then numa_meminfo may not

Re: [PATCH V2] x86/numa: kernel stack corruption fix

2015-04-07 Thread Dave Young
> > > > - /* Mark all kernel nodes. */ > > + /* > > +* Mark all kernel nodes. > > +* > > +* In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo > > Hi Dave, > > It should both set mem=xx and numa=off, then numa_meminfo may not include all > the memblock.reserved me

Re: [PATCH V2] x86/numa: kernel stack corruption fix

2015-04-07 Thread Xishi Qiu
On 2015/4/7 21:41, Dave Young wrote: > I got below kernel panic during kdump test on Thinkpad T420 laptop: > > [0.00] No NUMA configuration found > > [0.00] Faking a node at [mem 0x-0x37ba4fff] > > [0.00]

[PATCH V2] x86/numa: kernel stack corruption fix

2015-04-07 Thread Dave Young
I got below kernel panic during kdump test on Thinkpad T420 laptop: [0.00] No NUMA configuration found [0.00] Faking a node at [mem 0x-0x37ba4fff] [0.00] Kernel panic - not syncing: stack-protector: Kernel s