Re: [PATCH V2 0/6] VA to numa node information

2018-12-19 Thread Michal Hocko
On Tue 18-12-18 15:46:45, prakash.sangappa wrote: [...] > Dave Hansen asked how would it scale, with respect reading this file from > a large process. Answer is, the file contents are generated using page > table walk, and copied to user buffer. The mmap_sem lock is drop and > re-acquired in the pr

Re: [PATCH V2 0/6] VA to numa node information

2018-11-26 Thread Steven Sistare
On 11/9/2018 11:48 PM, Prakash Sangappa wrote: > On 9/24/18 10:14 AM, Michal Hocko wrote: >> On Fri 14-09-18 12:01:18, Steven Sistare wrote: >>> On 9/14/2018 1:56 AM, Michal Hocko wrote: >> [...] Why does this matter for something that is for analysis purposes. Reading the file for the wh

Re: [PATCH V2 0/6] VA to numa node information

2018-11-10 Thread Prakash Sangappa
On 9/24/18 10:14 AM, Michal Hocko wrote: On Fri 14-09-18 12:01:18, Steven Sistare wrote: On 9/14/2018 1:56 AM, Michal Hocko wrote: [...] Why does this matter for something that is for analysis purposes. Reading the file for the whole address space is far from a free operation. Is the page w

Re: [PATCH V2 0/6] VA to numa node information

2018-09-24 Thread Michal Hocko
On Fri 14-09-18 12:01:18, Steven Sistare wrote: > On 9/14/2018 1:56 AM, Michal Hocko wrote: [...] > > Why does this matter for something that is for analysis purposes. > > Reading the file for the whole address space is far from a free > > operation. Is the page walk optimization really essential f

Re: [PATCH V2 0/6] VA to numa node information

2018-09-14 Thread Prakash Sangappa
On 9/13/2018 5:25 PM, Dave Hansen wrote: On 09/13/2018 05:10 PM, Andrew Morton wrote: Also, VMAs having THP pages can have a mix of 4k pages and hugepages. The page walks would be efficient in scanning and determining if it is a THP huge page and step over it. Whereas using the API, the applicat

Re: [PATCH V2 0/6] VA to numa node information

2018-09-14 Thread Dave Hansen
On 09/14/2018 11:04 AM, Prakash Sangappa wrote: > Also, for valid VMAs in 'maps' file, if the VMA is sparsely > populated with physical pages, the page walk can skip over non > existing page table entires (PMDs) and so can be faster. Note that this only works for things that were _never_ populate

Re: [PATCH V2 0/6] VA to numa node information

2018-09-14 Thread Prakash Sangappa
On 9/14/18 9:01 AM, Steven Sistare wrote: On 9/14/2018 1:56 AM, Michal Hocko wrote: On Thu 13-09-18 15:32:25, prakash.sangappa wrote: The proc interface provides an efficient way to export address range to numa node id mapping information compared to using the API. Do you have any numbers?

Re: [PATCH V2 0/6] VA to numa node information

2018-09-14 Thread Steven Sistare
On 9/14/2018 1:56 AM, Michal Hocko wrote: > On Thu 13-09-18 15:32:25, prakash.sangappa wrote: >> On 09/13/2018 01:40 AM, Michal Hocko wrote: >>> On Wed 12-09-18 13:23:58, Prakash Sangappa wrote: For analysis purpose it is useful to have numa node information corresponding mapped virtual a

Re: [PATCH V2 0/6] VA to numa node information

2018-09-13 Thread Michal Hocko
On Thu 13-09-18 15:32:25, prakash.sangappa wrote: > > > On 09/13/2018 01:40 AM, Michal Hocko wrote: > > On Wed 12-09-18 13:23:58, Prakash Sangappa wrote: > > > For analysis purpose it is useful to have numa node information > > > corresponding mapped virtual address ranges of a process. Currently

Re: [PATCH V2 0/6] VA to numa node information

2018-09-13 Thread Dave Hansen
On 09/13/2018 05:10 PM, Andrew Morton wrote: >> Also, VMAs having THP pages can have a mix of 4k pages and hugepages. >> The page walks would be efficient in scanning and determining if it is >> a THP huge page and step over it. Whereas using the API, the application >> would not know what page siz

Re: [PATCH V2 0/6] VA to numa node information

2018-09-13 Thread Andrew Morton
On Thu, 13 Sep 2018 15:32:25 -0700 "prakash.sangappa" wrote: > >> https://marc.info/?t=15252407341&r=1&w=2 > > It would be really great to give a short summary of the previous > > discussion. E.g. why do we need a proc interface in the first place when > > we already have an API to query for

Re: [PATCH V2 0/6] VA to numa node information

2018-09-13 Thread prakash.sangappa
On 09/13/2018 01:40 AM, Michal Hocko wrote: On Wed 12-09-18 13:23:58, Prakash Sangappa wrote: For analysis purpose it is useful to have numa node information corresponding mapped virtual address ranges of a process. Currently, the file /proc//numa_maps provides list of numa nodes from where p

Re: [PATCH V2 0/6] VA to numa node information

2018-09-13 Thread Michal Hocko
On Wed 12-09-18 13:23:58, Prakash Sangappa wrote: > For analysis purpose it is useful to have numa node information > corresponding mapped virtual address ranges of a process. Currently, > the file /proc//numa_maps provides list of numa nodes from where pages > are allocated per VMA of a process. T

[PATCH V2 0/6] VA to numa node information

2018-09-12 Thread Prakash Sangappa
For analysis purpose it is useful to have numa node information corresponding mapped virtual address ranges of a process. Currently, the file /proc//numa_maps provides list of numa nodes from where pages are allocated per VMA of a process. This is not useful if an user needs to determine which numa