Re: [PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk()

2013-02-14 Thread Jingoo Han
On Friday, February 15, 2013 3:50 PM, Joe Perches wrote: > On Fri, 2013-02-15 at 15:46 +0900, Jingoo Han wrote: > > Fixed the checkpatch warning as below: > [] > > diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c > [] > > @@ -39,6 +39,8 @@ > > * 1.13Nobuhiro Iwamatsu:

Re: [PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk()

2013-02-14 Thread Joe Perches
On Fri, 2013-02-15 at 15:46 +0900, Jingoo Han wrote: > Fixed the checkpatch warning as below: [] > diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c [] > @@ -39,6 +39,8 @@ > * 1.13Nobuhiro Iwamatsu: Updata driver. > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >

[PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk()

2013-02-14 Thread Jingoo Han
Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- No changes since v1: drivers/rtc/rtc-rs5c313.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff

Re: [PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk()

2013-02-14 Thread Joe Perches
On Fri, 2013-02-15 at 15:46 +0900, Jingoo Han wrote: Fixed the checkpatch warning as below: [] diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c [] @@ -39,6 +39,8 @@ * 1.13Nobuhiro Iwamatsu: Updata driver. */ +#define pr_fmt(fmt) KBUILD_MODNAME : fmt +

Re: [PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk()

2013-02-14 Thread Jingoo Han
On Friday, February 15, 2013 3:50 PM, Joe Perches wrote: On Fri, 2013-02-15 at 15:46 +0900, Jingoo Han wrote: Fixed the checkpatch warning as below: [] diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c [] @@ -39,6 +39,8 @@ * 1.13Nobuhiro Iwamatsu: Updata driver.