Re: [PATCH V2 09/10] x86/resctrl: Pseudo-lock portions of multiple resources

2019-08-09 Thread Reinette Chatre
Hi Borislav, On 8/9/2019 12:38 AM, Borislav Petkov wrote: > On Thu, Aug 08, 2019 at 01:13:46PM -0700, Reinette Chatre wrote: >> There is a locking order dependency between cpu_hotplug_lock and >> rdtgroup_mutex (cpu_hotplug_lock before rdtgroup_mutex) that has to be >> maintained. To do so in this

Re: [PATCH V2 09/10] x86/resctrl: Pseudo-lock portions of multiple resources

2019-08-09 Thread Borislav Petkov
On Thu, Aug 08, 2019 at 01:13:46PM -0700, Reinette Chatre wrote: > There is a locking order dependency between cpu_hotplug_lock and > rdtgroup_mutex (cpu_hotplug_lock before rdtgroup_mutex) that has to be > maintained. To do so in this flow you will find cpus_read_lock() in > rdtgroup_schemata_writ

Re: [PATCH V2 09/10] x86/resctrl: Pseudo-lock portions of multiple resources

2019-08-08 Thread Reinette Chatre
Hi Borislav, On 8/8/2019 1:44 AM, Borislav Petkov wrote: > On Wed, Aug 07, 2019 at 12:23:29PM -0700, Reinette Chatre wrote: >> I do not fully understand this proposal. All those goto labels take care >> of the the different failures that can be encountered during the >> initialization of the pseud

Re: [PATCH V2 09/10] x86/resctrl: Pseudo-lock portions of multiple resources

2019-08-08 Thread Borislav Petkov
On Wed, Aug 07, 2019 at 12:23:29PM -0700, Reinette Chatre wrote: > I do not fully understand this proposal. All those goto labels take care > of the the different failures that can be encountered during the > initialization of the pseudo-lock region. Each initialization failure is > associated with

Re: [PATCH V2 09/10] x86/resctrl: Pseudo-lock portions of multiple resources

2019-08-07 Thread Reinette Chatre
Hi Borislav, On 8/7/2019 8:25 AM, Borislav Petkov wrote: > On Tue, Jul 30, 2019 at 10:29:43AM -0700, Reinette Chatre wrote: >> A cache pseudo-locked region may span more than one level of cache. A >> part of the pseudo-locked region that falls on one cache level is >> referred to as a pseudo-lock

Re: [PATCH V2 09/10] x86/resctrl: Pseudo-lock portions of multiple resources

2019-08-07 Thread Borislav Petkov
On Tue, Jul 30, 2019 at 10:29:43AM -0700, Reinette Chatre wrote: > A cache pseudo-locked region may span more than one level of cache. A > part of the pseudo-locked region that falls on one cache level is > referred to as a pseudo-lock portion that was introduced previously. > > Now a pseudo-locke

[PATCH V2 09/10] x86/resctrl: Pseudo-lock portions of multiple resources

2019-07-30 Thread Reinette Chatre
A cache pseudo-locked region may span more than one level of cache. A part of the pseudo-locked region that falls on one cache level is referred to as a pseudo-lock portion that was introduced previously. Now a pseudo-locked region is allowed to have two portions instead of the previous limit of o