RE: [PATCH V2 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread KY Srinivasan
; jasow...@redhat.com; linux- > ker...@vger.kernel.org; h...@zytor.com > Subject: Re: [PATCH V2 1/1] X86: Probe for PIC and set legacy_pic > appropriately > > >>> On 12.04.14 at 07:56, wrote: > > --- a/arch/x86/kernel/i8259.c > > +++ b/arch/x86/kernel/i8259.

Re: [PATCH V2 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread Olaf Hering
On Fri, Apr 11, K. Y. Srinivasan wrote: > Probe for the existance of legacy PIC, if one does not exist, use the > null_legacy_pic. > Signed-off-by: K. Y. Srinivasan Tested-by: Olaf Hering Fixes the crash on Gen1 VMs for me, which was introduced by "x86/platform/hyperv: When on Hyper-v use NUL

Re: [PATCH V2 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread Jan Beulich
>>> On 12.04.14 at 07:56, wrote: > --- a/arch/x86/kernel/i8259.c > +++ b/arch/x86/kernel/i8259.c > @@ -299,11 +299,30 @@ static void unmask_8259A(void) > static void init_8259A(int auto_eoi) > { > unsigned long flags; > + unsigned char probe_val = ~(1 << PIC_CASCADE_IR); > + unsign

[PATCH V2 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-11 Thread K. Y. Srinivasan
Probe for the existance of legacy PIC, if one does not exist, use the null_legacy_pic. This patch implements the proposal put forth by H. Peter Anvin . In version V1 of the patch, I had cleaned up the code based on comments from Peter. In this version of the patch, I have addressed additional