Re: [PATCH V2 1/2] ftrace: Make saved_cmdlines use seq_read

2014-05-29 Thread Steven Rostedt
On Thu, 20 Feb 2014 17:44:31 +0900 Yoshihiro YUNOMAE wrote: > Current tracing_saved_cmdlines_read() implementation is naive; > simply allocate a big buffer, construct output data on the > buffer for each read operation, and then copy a portion of > the buffer to the user space buffer. This can

Re: [PATCH V2 1/2] ftrace: Make saved_cmdlines use seq_read

2014-05-29 Thread Steven Rostedt
On Thu, 20 Feb 2014 17:44:31 +0900 Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote: Current tracing_saved_cmdlines_read() implementation is naive; simply allocate a big buffer, construct output data on the buffer for each read operation, and then copy a portion of the buffer to the

[PATCH V2 1/2] ftrace: Make saved_cmdlines use seq_read

2014-02-20 Thread Yoshihiro YUNOMAE
Current tracing_saved_cmdlines_read() implementation is naive; simply allocate a big buffer, construct output data on the buffer for each read operation, and then copy a portion of the buffer to the user space buffer. This can cause a couple of issues such as a slow memory allocation, high cpu

[PATCH V2 1/2] ftrace: Make saved_cmdlines use seq_read

2014-02-20 Thread Yoshihiro YUNOMAE
Current tracing_saved_cmdlines_read() implementation is naive; simply allocate a big buffer, construct output data on the buffer for each read operation, and then copy a portion of the buffer to the user space buffer. This can cause a couple of issues such as a slow memory allocation, high cpu