Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-21 Thread Wei Yang
On Wed, Dec 21, 2016 at 01:48:17PM +0100, Michal Hocko wrote: >On Wed 21-12-16 12:43:20, Wei Yang wrote: >> On Wed, Dec 21, 2016 at 08:48:09AM +0100, Michal Hocko wrote: >> >On Tue 20-12-16 16:35:40, Wei Yang wrote: >> >> On Mon, Dec 19, 2016 at 04:15:14PM +0100, Michal Hocko wrote: >> >> >On Sun 1

Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-21 Thread Michal Hocko
On Wed 21-12-16 12:43:20, Wei Yang wrote: > On Wed, Dec 21, 2016 at 08:48:09AM +0100, Michal Hocko wrote: > >On Tue 20-12-16 16:35:40, Wei Yang wrote: > >> On Mon, Dec 19, 2016 at 04:15:14PM +0100, Michal Hocko wrote: > >> >On Sun 18-12-16 14:47:49, Wei Yang wrote: > >> >> The base address is alrea

Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-21 Thread Wei Yang
On Wed, Dec 21, 2016 at 08:48:09AM +0100, Michal Hocko wrote: >On Tue 20-12-16 16:35:40, Wei Yang wrote: >> On Mon, Dec 19, 2016 at 04:15:14PM +0100, Michal Hocko wrote: >> >On Sun 18-12-16 14:47:49, Wei Yang wrote: >> >> The base address is already guaranteed to be in the region by >> >> memblock_

Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-20 Thread Michal Hocko
On Tue 20-12-16 16:35:40, Wei Yang wrote: > On Mon, Dec 19, 2016 at 04:15:14PM +0100, Michal Hocko wrote: > >On Sun 18-12-16 14:47:49, Wei Yang wrote: > >> The base address is already guaranteed to be in the region by > >> memblock_search(). > > > > Hi, Michal > > Nice to receive your comment. >

Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-20 Thread Wei Yang
On Mon, Dec 19, 2016 at 04:15:14PM +0100, Michal Hocko wrote: >On Sun 18-12-16 14:47:49, Wei Yang wrote: >> The base address is already guaranteed to be in the region by >> memblock_search(). > Hi, Michal Nice to receive your comment. >First of all the way how the check is removed is the worst p

Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-19 Thread Michal Hocko
On Sun 18-12-16 14:47:49, Wei Yang wrote: > The base address is already guaranteed to be in the region by > memblock_search(). First of all the way how the check is removed is the worst possible... Apart from that it is really not clear to me why checking the base is not needed. You are mentioning

[PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-18 Thread Wei Yang
The base address is already guaranteed to be in the region by memblock_search(). This patch removes the check on base. Signed-off-by: Wei Yang --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index 7608bc3..cd85303 100644 --- a/