RE: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

2015-08-28 Thread Liang, Kan
l.com; > a.p.zijls...@chello.nl; Ingo Molnar; linux-kernel@vger.kernel.org > Subject: Re: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr > > Em Fri, Aug 28, 2015 at 02:39:21PM +, Liang, Kan escreveu: > > > In this case it needs to go to perf/urgent, where it app

Re: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

2015-08-28 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 28, 2015 at 02:39:21PM +, Liang, Kan escreveu: > > In this case it needs to go to perf/urgent, where it applies > > cleanly, perf/core has extra stuff there that fuzzes a bit. > > Also, since you know the cset where this bug was introduced, please > > consider adding a "Fixes:" tag

Re: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

2015-08-28 Thread Stephane Eranian
On Fri, Aug 28, 2015 at 7:39 AM, Liang, Kan wrote: > > > > > Em Fri, Aug 28, 2015 at 01:33:22PM +, Liang, Kan escreveu: > > > > On Thu, Jul 02, 2015 at 03:08:43AM -0400, kan.li...@intel.com wrote: > > > > > From: Kan Liang print_aggr fails to print > > > > > per-core/per-socket statistics aft

RE: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

2015-08-28 Thread Liang, Kan
> > Em Fri, Aug 28, 2015 at 01:33:22PM +, Liang, Kan escreveu: > > > On Thu, Jul 02, 2015 at 03:08:43AM -0400, kan.li...@intel.com wrote: > > > > From: Kan Liang print_aggr fails to print > > > > per-core/per-socket statistics after commit 582ec0829b3d ("perf > > > > stat: Fix per-socket outp

Re: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

2015-08-28 Thread a...@kernel.org
Em Fri, Aug 28, 2015 at 01:33:22PM +, Liang, Kan escreveu: > > On Thu, Jul 02, 2015 at 03:08:43AM -0400, kan.li...@intel.com wrote: > > > From: Kan Liang > > > print_aggr fails to print per-core/per-socket statistics after commit > > > 582ec0829b3d ("perf stat: Fix per-socket output bug for un

RE: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

2015-08-28 Thread Liang, Kan
> On Thu, Jul 02, 2015 at 03:08:43AM -0400, kan.li...@intel.com wrote: > > From: Kan Liang > > > > print_aggr fails to print per-core/per-socket statistics after commit > > 582ec0829b3d ("perf stat: Fix per-socket output bug for uncore > > events") if events have differnt cpus. Because in print_

Re: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

2015-07-02 Thread Jiri Olsa
On Thu, Jul 02, 2015 at 03:08:43AM -0400, kan.li...@intel.com wrote: > From: Kan Liang > > print_aggr fails to print per-core/per-socket statistics after commit > 582ec0829b3d ("perf stat: Fix per-socket output bug for uncore events") > if events have differnt cpus. Because in print_aggr, aggr_ge

[PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

2015-07-02 Thread kan . liang
From: Kan Liang print_aggr fails to print per-core/per-socket statistics after commit 582ec0829b3d ("perf stat: Fix per-socket output bug for uncore events") if events have differnt cpus. Because in print_aggr, aggr_get_id needs index (not cpu id) to find core/pkg id. Also, evsel cpu maps should