Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Guenter Roeck
On 04/02/2015 07:35 PM, Guenter Roeck wrote: On 04/02/2015 07:16 PM, Andrew Bresticker wrote: Hi Guenter, On Thu, Apr 2, 2015 at 6:52 PM, Guenter Roeck wrote: On 04/02/2015 09:46 AM, Andrew Bresticker wrote: On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck wrote: On 04/01/2015 03:22 PM,

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Guenter Roeck
On 04/02/2015 07:16 PM, Andrew Bresticker wrote: Hi Guenter, On Thu, Apr 2, 2015 at 6:52 PM, Guenter Roeck wrote: On 04/02/2015 09:46 AM, Andrew Bresticker wrote: On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck wrote: On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Andrew Bresticker
Hi Guenter, On Thu, Apr 2, 2015 at 6:52 PM, Guenter Roeck wrote: > On 04/02/2015 09:46 AM, Andrew Bresticker wrote: >> >> On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck wrote: >>> >>> On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr 01, 2015 at

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Guenter Roeck
On 04/02/2015 09:46 AM, Andrew Bresticker wrote: On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck wrote: On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Andrew Bresticker
On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck wrote: > On 04/01/2015 03:22 PM, James Hogan wrote: >> >> Hi Andrew, >> >> On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: >>> >>> Since the heartbeat is statically initialized to its default value, >>> watchdog_init_timeout() will

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Guenter Roeck
On 04/02/2015 09:46 AM, Andrew Bresticker wrote: On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck li...@roeck-us.net wrote: On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: Since the heartbeat is statically initialized to

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Andrew Bresticker
Hi Guenter, On Thu, Apr 2, 2015 at 6:52 PM, Guenter Roeck li...@roeck-us.net wrote: On 04/02/2015 09:46 AM, Andrew Bresticker wrote: On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck li...@roeck-us.net wrote: On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr 01, 2015 at

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Guenter Roeck
On 04/02/2015 07:16 PM, Andrew Bresticker wrote: Hi Guenter, On Thu, Apr 2, 2015 at 6:52 PM, Guenter Roeck li...@roeck-us.net wrote: On 04/02/2015 09:46 AM, Andrew Bresticker wrote: On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck li...@roeck-us.net wrote: On 04/01/2015 03:22 PM, James Hogan

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Guenter Roeck
On 04/02/2015 07:35 PM, Guenter Roeck wrote: On 04/02/2015 07:16 PM, Andrew Bresticker wrote: Hi Guenter, On Thu, Apr 2, 2015 at 6:52 PM, Guenter Roeck li...@roeck-us.net wrote: On 04/02/2015 09:46 AM, Andrew Bresticker wrote: On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck li...@roeck-us.net

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-02 Thread Andrew Bresticker
On Wed, Apr 1, 2015 at 6:08 PM, Guenter Roeck li...@roeck-us.net wrote: On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread Guenter Roeck
On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec value. Instead of

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread Guenter Roeck
On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec value. Instead of

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread Andrew Bresticker
Hi James, On Wed, Apr 1, 2015 at 3:22 PM, James Hogan wrote: > Hi Andrew, > > On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: >> Since the heartbeat is statically initialized to its default value, >> watchdog_init_timeout() will never look in the device-tree for a >>

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread James Hogan
Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: > Since the heartbeat is statically initialized to its default value, > watchdog_init_timeout() will never look in the device-tree for a > timeout-sec value. Instead of statically initializing heartbeat, > fall back to

[PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread Andrew Bresticker
Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec value. Instead of statically initializing heartbeat, fall back to the default timeout value if watchdog_init_timeout() fails. Signed-off-by: Andrew

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread Guenter Roeck
On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec value. Instead of

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread Guenter Roeck
On 04/01/2015 03:22 PM, James Hogan wrote: Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec value. Instead of

[PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread Andrew Bresticker
Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec value. Instead of statically initializing heartbeat, fall back to the default timeout value if watchdog_init_timeout() fails. Signed-off-by: Andrew

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread James Hogan
Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec value. Instead of statically initializing heartbeat, fall back to the

Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-01 Thread Andrew Bresticker
Hi James, On Wed, Apr 1, 2015 at 3:22 PM, James Hogan james.ho...@imgtec.com wrote: Hi Andrew, On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for