On Fri, 29 Jan 2016, Andy Shevchenko wrote:
> Thin out Cc list since mostly off topic message here.
>
> On Fri, 2016-01-29 at 08:21 +, Lee Jones wrote:
>
> > I prefer '-' in MFD.
>
> Have to memorize that.
>
> /* A bit of off topic */
> I will cook and send one patch regarding to Intel Qua
Hi Andy,
Andy Shevchenko 於 2016/1/29 下午 09:41 寫道:
On Fri, 2016-01-29 at 13:50 +0800, Peter Hung wrote:
Andy Shevchenko 於 2016/1/28 下午 07:55 寫道:
I would suggest to rearrange definition block here (and in the rest
of
the functions in entire series) to somehow follow the following
pattern
1) ass
On Fri, 2016-01-29 at 13:50 +0800, Peter Hung wrote:
> Andy Shevchenko 於 2016/1/28 下午 07:55 寫道:
> > > +obj-$(CONFIG_MFD_FINTEK_F81504_CORE) += f81504-core.o
> +static int f81504_port_init(struct pci_dev *dev)
> > > +{
> > > + size_t i, j;
> > > + u32 max_port, iobase, gpio_addr;
> > > + u32 b
Thin out Cc list since mostly off topic message here.
On Fri, 2016-01-29 at 08:21 +, Lee Jones wrote:
> I prefer '-' in MFD.
Have to memorize that.
/* A bit of off topic */
I will cook and send one patch regarding to Intel Quark SoC, i.e. UART
driver, but I'm not sure it's a good idea now t
On Fri, 29 Jan 2016, Peter Hung wrote:
> >>+obj-$(CONFIG_MFD_FINTEK_F81504_CORE) += f81504-core.o
> >
> >I think '_' is better than '-'. What I saw and usually do is '_' for
> >regular source modules and '-' for the resulting objects when they have
> >more than one file.
>
> I used f81504_co
Hi Andy,
Andy Shevchenko 於 2016/1/28 下午 07:55 寫道:
+default y
I'm not sure we have to have this always y. Perhaps
default SERIAL_8250_PCI
Your comment is right, this device major function is serial port.
GPIO maybe not enabled by H/W manufacturer.
I'll set it default with SERIAL_8250
Hi Alan,
One Thousand Gnomes 於 2016/1/28 下午 06:04 寫道:
+ Please bulit-in kernel if you need early console support.
This driver needs to be built into the kernel to use early console
support.
ok
+ switch (dev->device) {
+ case FINTEK_F81504: /* 4 ports */
+
On Thu, 2016-01-28 at 17:20 +0800, Peter Hung wrote:
> The Fintek F81504/508/512 had implemented the basic serial port
> function in
> 8250_pci.c. We try to implement high baudrate & GPIOLIB with a spilt
> file
> 8250_f81504.c, but it seems too complex to add GPIOLIB.
>
> Alan & Andy recommend us
> +config MFD_FINTEK_F81504_CORE
> +tristate "Fintek F81504/508/512 PCIE-to-UART/GPIO MFD support"
> +depends on PCI
> +select MFD_CORE
> +default y
> +help
> + This driver generate F81504/508/512 UART & GPIO platform
This driver provides the F81504/
The Fintek F81504/508/512 had implemented the basic serial port function in
8250_pci.c. We try to implement high baudrate & GPIOLIB with a spilt file
8250_f81504.c, but it seems too complex to add GPIOLIB.
Alan & Andy recommend us to rewrite and spilt our driver with MFD
architecture.
https://lkml
10 matches
Mail list logo
