Re: [PATCH V2 1/5] bindings: regulator: added support for suspend states

2018-01-09 Thread Mark Brown
On Tue, Jan 09, 2018 at 02:08:45PM +0800, Chunyan Zhang wrote: > Then, do we need a flag as well to give permission to change > 'suspend_state->enabled'? Yes, that's a separate thing which people might want to control even if the voltage can't be changed. signature.asc Description: PGP signatur

Re: [PATCH V2 1/5] bindings: regulator: added support for suspend states

2018-01-08 Thread Chunyan Zhang
On 8 January 2018 at 20:35, Mark Brown wrote: > On Mon, Jan 08, 2018 at 02:36:36PM +0800, Chunyan Zhang wrote: >> On 6 January 2018 at 03:18, Mark Brown wrote: > >> > No, it means that the software has permission to use those changes to >> > those registers - we only want to be changing things if

Re: [PATCH V2 1/5] bindings: regulator: added support for suspend states

2018-01-08 Thread Mark Brown
On Mon, Jan 08, 2018 at 02:36:36PM +0800, Chunyan Zhang wrote: > On 6 January 2018 at 03:18, Mark Brown wrote: > > No, it means that the software has permission to use those changes to > > those registers - we only want to be changing things if the user has > > permission to change them since som

Re: [PATCH V2 1/5] bindings: regulator: added support for suspend states

2018-01-07 Thread Chunyan Zhang
On 6 January 2018 at 03:18, Mark Brown wrote: > On Fri, Jan 05, 2018 at 12:53:28PM -0600, Rob Herring wrote: >> On Thu, Jan 04, 2018 at 03:22:44PM +0800, Chunyan Zhang wrote: > >> > + - regulator-suspend-microvolt: the default voltage which regulator >> > + would be set in suspend. The volta

Re: [PATCH V2 1/5] bindings: regulator: added support for suspend states

2018-01-05 Thread Mark Brown
On Fri, Jan 05, 2018 at 12:53:28PM -0600, Rob Herring wrote: > On Thu, Jan 04, 2018 at 03:22:44PM +0800, Chunyan Zhang wrote: > > + - regulator-suspend-microvolt: the default voltage which regulator > > + would be set in suspend. The voltage for suspend also can be > > + adjusted among {

Re: [PATCH V2 1/5] bindings: regulator: added support for suspend states

2018-01-05 Thread Rob Herring
On Thu, Jan 04, 2018 at 03:22:44PM +0800, Chunyan Zhang wrote: > Some systems need to set regulators to specific states when they enter > low power modes, especially around CPUs. There are many of these modes > depending on the particular runtime state. > > Currently the regulator consumers are no

[PATCH V2 1/5] bindings: regulator: added support for suspend states

2018-01-03 Thread Chunyan Zhang
Some systems need to set regulators to specific states when they enter low power modes, especially around CPUs. There are many of these modes depending on the particular runtime state. Currently the regulator consumers are not granted permission to change suspend state of regulator devices, the co