Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-08 Thread David Miller
From: KY Srinivasan Date: Sat, 8 Mar 2014 10:27:54 + > "len" would have gotten decremented prior to the check and in the > case we are talking about, "len" would be zero and so j would not > get incremented. You are correct, this is the part of the logic in this case which I missed.

RE: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-08 Thread KY Srinivasan
; jasow...@redhat.com > Subject: Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O > > From: KY Srinivasan > Date: Sat, 8 Mar 2014 04:12:01 + > > > > > > >> -Original Message- > >> From: David Miller [mailto:da...@davemloft.net]

RE: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-08 Thread KY Srinivasan
: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O From: KY Srinivasan k...@microsoft.com Date: Sat, 8 Mar 2014 04:12:01 + -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Saturday, March 8, 2014 3:18 AM To: KY Srinivasan Cc: net

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-08 Thread David Miller
From: KY Srinivasan k...@microsoft.com Date: Sat, 8 Mar 2014 10:27:54 + len would have gotten decremented prior to the check and in the case we are talking about, len would be zero and so j would not get incremented. You are correct, this is the part of the logic in this case which I

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
linux-kernel@vger.kernel.org; >> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; >> jasow...@redhat.com >> Subject: Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O >> >> From: "K. Y. Srinivasan" >> Date: Thu, 6 Mar 2014 21:3

RE: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread KY Srinivasan
; jasow...@redhat.com > Subject: Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O > > From: "K. Y. Srinivasan" > Date: Thu, 6 Mar 2014 21:32:36 -0800 > > > +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, > > +

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 21:32:36 -0800 > +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, > + struct hv_page_buffer *pb) > +{ > + int j = 0; > + > + /* Deal with compund pages by ignoring unused part > + * of the page. > +

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 21:32:36 -0800 +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, + struct hv_page_buffer *pb) +{ + int j = 0; + + /* Deal with compund pages by ignoring unused part + * of the

RE: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread KY Srinivasan
: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 21:32:36 -0800 +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, + struct hv_page_buffer *pb) +{ + int j = 0

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com Subject: Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 21:32:36 -0800 +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len

[PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-06 Thread K. Y. Srinivasan
Cleanup the code and enable scatter gather I/O. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 153 +-- 1 files changed, 114 insertions(+), 39 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c

[PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-06 Thread K. Y. Srinivasan
Cleanup the code and enable scatter gather I/O. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Reviewed-by: Haiyang Zhang haiya...@microsoft.com --- drivers/net/hyperv/netvsc_drv.c | 153 +-- 1 files changed, 114 insertions(+), 39 deletions(-) diff --git