Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-02-14 Thread Eddie Cai
Hi 2017-02-09 7:07 GMT+08:00 Heiko Stuebner : > Hi Eddie > > Am Montag, 6. Februar 2017, 10:14:47 CET schrieb Eddie Cai: >> This patch add basic support for RK3288-Tinker board. We can boot in to >> rootfs with this patch. >> >> Signed-off-by: Eddie Cai >> --- > > [...] > >> +&hdmi { >> + #ad

Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-02-08 Thread Andy Yan
Hi Eddie: On 2017年02月06日 10:14, Eddie Cai wrote: This patch add basic support for RK3288-Tinker board. We can boot in to rootfs with this patch. Signed-off-by: Eddie Cai --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/rk3288-tinker.dts | 543 +

Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-02-08 Thread Heiko Stuebner
Hi Eddie Am Montag, 6. Februar 2017, 10:14:47 CET schrieb Eddie Cai: > This patch add basic support for RK3288-Tinker board. We can boot in to > rootfs with this patch. > > Signed-off-by: Eddie Cai > --- [...] > +&hdmi { > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-d

Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-02-05 Thread Eddie Cai
Hi Andrew 2017-02-06 10:54 GMT+08:00 Andrew Lunn : > Hi Eddie > >> + button@0 { >> + gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; >> + linux,code = <116>; > > It is a good idea to use include/dt-bindings/input/input.h > > and then you can replace <116> wi

Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-02-05 Thread Andrew Lunn
Hi Eddie > + button@0 { > + gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; > + linux,code = <116>; It is a good idea to use include/dt-bindings/input/input.h and then you can replace <116> with < KEY_POWER > which is more readable. > +

[PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board

2017-02-05 Thread Eddie Cai
This patch add basic support for RK3288-Tinker board. We can boot in to rootfs with this patch. Signed-off-by: Eddie Cai --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/rk3288-tinker.dts | 543 2 files changed, 544 insertions(+) create mod