Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-19 Thread Nishanth Menon
Hi Jassi, On 03/16/2016 12:16 AM, Jassi Brar wrote: [...] >> Alright, i will drop this check since it is causing a lot more >> confusion >> > It's confusing because you check ti_msgmgr_queue_get_num_messages() > also in ti_msgmgr_last_tx_done() which doesn't make sense because the > former accoun

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-15 Thread Jassi Brar
On Tue, Mar 15, 2016 at 10:35 PM, Nishanth Menon wrote: > On Tue, Mar 15, 2016 at 12:31 AM, Jassi Brar wrote: >> On Tue, Mar 8, 2016 at 8:07 PM, Nishanth Menon wrote: >>> Jassi, >>> >>> On Tue, Mar 8, 2016 at 1:10 AM, Jassi Brar wrote: On Tue, Mar 8, 2016 at 2:18 AM, Nishanth Menon wrote:

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-15 Thread Nishanth Menon
On Tue, Mar 15, 2016 at 12:31 AM, Jassi Brar wrote: > On Tue, Mar 8, 2016 at 8:07 PM, Nishanth Menon wrote: >> Jassi, >> >> On Tue, Mar 8, 2016 at 1:10 AM, Jassi Brar wrote: >>> On Tue, Mar 8, 2016 at 2:18 AM, Nishanth Menon wrote: On 03/07/2016 12:31 PM, Jassi Brar wrote: > On Fri, Ma

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-14 Thread Jassi Brar
On Tue, Mar 8, 2016 at 8:07 PM, Nishanth Menon wrote: > Jassi, > > On Tue, Mar 8, 2016 at 1:10 AM, Jassi Brar wrote: >> On Tue, Mar 8, 2016 at 2:18 AM, Nishanth Menon wrote: >>> On 03/07/2016 12:31 PM, Jassi Brar wrote: On Fri, Mar 4, 2016 at 8:05 PM, Nishanth Menon wrote: >> >>> +

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-08 Thread Nishanth Menon
Jassi, On Tue, Mar 8, 2016 at 1:10 AM, Jassi Brar wrote: > On Tue, Mar 8, 2016 at 2:18 AM, Nishanth Menon wrote: >> On 03/07/2016 12:31 PM, Jassi Brar wrote: >>> On Fri, Mar 4, 2016 at 8:05 PM, Nishanth Menon wrote: > >> +static int ti_msgmgr_send_data(struct mbox_chan *chan, void *data

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-07 Thread Jassi Brar
On Tue, Mar 8, 2016 at 2:18 AM, Nishanth Menon wrote: > On 03/07/2016 12:31 PM, Jassi Brar wrote: >> On Fri, Mar 4, 2016 at 8:05 PM, Nishanth Menon wrote: > +static int ti_msgmgr_send_data(struct mbox_chan *chan, void *data) > +{ > + struct device *dev = chan->mbox->dev; >>

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-07 Thread Nishanth Menon
On 03/07/2016 12:31 PM, Jassi Brar wrote: > On Fri, Mar 4, 2016 at 8:05 PM, Nishanth Menon wrote: >> Hi Jassi, >> >> Thanks for reviewing the patch. >> On 03/03/2016 11:18 PM, Jassi Brar wrote: >> >> [...] >> drivers/mailbox/Kconfig | 11 + drivers/mailbox/Makefile| 2 +

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-07 Thread Jassi Brar
On Fri, Mar 4, 2016 at 8:05 PM, Nishanth Menon wrote: > Hi Jassi, > > Thanks for reviewing the patch. > On 03/03/2016 11:18 PM, Jassi Brar wrote: > > [...] > >>> >>> drivers/mailbox/Kconfig | 11 + >>> drivers/mailbox/Makefile| 2 + >>> drivers/mailbox/ti-msgmgr.c | 657 > >> Do you wan

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-04 Thread Nishanth Menon
Hi Jassi, Thanks for reviewing the patch. On 03/03/2016 11:18 PM, Jassi Brar wrote: [...] >> >> drivers/mailbox/Kconfig | 11 + >> drivers/mailbox/Makefile| 2 + >> drivers/mailbox/ti-msgmgr.c | 657 > Do you want to call it something more specific than 'msgmgr from TI'? > Maybe its

Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-03-03 Thread Jassi Brar
On Sat, Feb 27, 2016 at 3:54 AM, Nishanth Menon wrote: > Support for TI Message Manager Module. This hardware block manages a > bunch of hardware queues meant for communication between processor > entities. > > Clients sitting on top of this would manage the required protocol > for communicating w

[PATCH V2 2/2] mailbox: Introduce TI message manager driver

2016-02-26 Thread Nishanth Menon
Support for TI Message Manager Module. This hardware block manages a bunch of hardware queues meant for communication between processor entities. Clients sitting on top of this would manage the required protocol for communicating with the counterpart entities. For more details on TI Message Manag