Re: [llvmlinux] [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-05 Thread Bryce Lelbach
On 2012.12.04 23.24, Sebastian Andrzej Siewior wrote: > > VLAIS is not something they are willing to accept (for various > > reasons). There are other patches to LLVM that are still working > Is this not described in C99 6.7.2.1p16? No, this is not the case - flexible array members are a very

Re: [llvmlinux] [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-05 Thread Bryce Lelbach
On 2012.12.04 23.24, Sebastian Andrzej Siewior wrote: VLAIS is not something they are willing to accept (for various reasons). There are other patches to LLVM that are still working Is this not described in C99 6.7.2.1p16? No, this is not the case - flexible array members are a very

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-04 Thread Behan Webster
On 12-12-04 11:24 PM, Sebastian Andrzej Siewior wrote: On Mon, Dec 03, 2012 at 07:57:33PM +0100, Behan Webster wrote: However, in order to approximate what gcc is doing in code, obviously some math is required. The thought was that macros would hide the worst of it, trying not to obfuscate what

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-04 Thread Sebastian Andrzej Siewior
On Mon, Dec 03, 2012 at 07:57:33PM +0100, Behan Webster wrote: > However, in order to approximate what gcc is doing in code, obviously > some math is required. The thought was that macros would hide the > worst of it, trying not to obfuscate what was actually being done. Why hide? The thing that

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-04 Thread Sebastian Andrzej Siewior
On Mon, Dec 03, 2012 at 07:57:33PM +0100, Behan Webster wrote: However, in order to approximate what gcc is doing in code, obviously some math is required. The thought was that macros would hide the worst of it, trying not to obfuscate what was actually being done. Why hide? The thing that is

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-04 Thread Behan Webster
On 12-12-04 11:24 PM, Sebastian Andrzej Siewior wrote: On Mon, Dec 03, 2012 at 07:57:33PM +0100, Behan Webster wrote: However, in order to approximate what gcc is doing in code, obviously some math is required. The thought was that macros would hide the worst of it, trying not to obfuscate what

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-03 Thread Behan Webster
On 12-12-03 12:57 PM, Sebastian Andrzej Siewior wrote: On Thu, Nov 01, 2012 at 09:21:16AM +0200, Felipe Balbi wrote: then we can merge to net tree and handle the conflicts when merging to Linus, that'd be fine by me as long as people know how to solve the conflict properly ;-) Felipe please

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-03 Thread Sebastian Andrzej Siewior
On Thu, Nov 01, 2012 at 09:21:16AM +0200, Felipe Balbi wrote: > then we can merge to net tree and handle the conflicts when merging to > Linus, that'd be fine by me as long as people know how to solve the > conflict properly ;-) Felipe please drop this patch. I don't like this VLAIS patch and its

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-03 Thread Sebastian Andrzej Siewior
On Thu, Nov 01, 2012 at 09:21:16AM +0200, Felipe Balbi wrote: then we can merge to net tree and handle the conflicts when merging to Linus, that'd be fine by me as long as people know how to solve the conflict properly ;-) Felipe please drop this patch. I don't like this VLAIS patch and its

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-03 Thread Behan Webster
On 12-12-03 12:57 PM, Sebastian Andrzej Siewior wrote: On Thu, Nov 01, 2012 at 09:21:16AM +0200, Felipe Balbi wrote: then we can merge to net tree and handle the conflicts when merging to Linus, that'd be fine by me as long as people know how to solve the conflict properly ;-) Felipe please

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-11-01 Thread David Miller
From: Felipe Balbi Date: Thu, 1 Nov 2012 09:21:16 +0200 > then we can merge to net tree and handle the conflicts when merging to > Linus, that'd be fine by me as long as people know how to solve the > conflict properly ;-) Like Herbert with the crypto tree, I'm simply not merging this absolute

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-11-01 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 11:33:20AM -0400, Behan Webster wrote: > On 12-10-31 09:28 AM, Felipe Balbi wrote: > >hi, > > > >On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: > >>The use of variable length arrays in structs (VLAIS) in the Linux Kernel > >>code > >>precludes the use

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-11-01 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 11:33:20AM -0400, Behan Webster wrote: On 12-10-31 09:28 AM, Felipe Balbi wrote: hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-11-01 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Thu, 1 Nov 2012 09:21:16 +0200 then we can merge to net tree and handle the conflicts when merging to Linus, that'd be fine by me as long as people know how to solve the conflict properly ;-) Like Herbert with the crypto tree, I'm simply not merging this

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Behan Webster
On 12-10-31 09:28 AM, Felipe Balbi wrote: hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Felipe Balbi
hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: > The use of variable length arrays in structs (VLAIS) in the Linux Kernel code > precludes the use of compilers which don't implement VLAIS (for instance the > Clang compiler). This patch instead calculates offsets into the

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Felipe Balbi
hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch instead calculates offsets into the

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Behan Webster
On 12-10-31 09:28 AM, Felipe Balbi wrote: hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch

[PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-30 Thread Behan Webster
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch instead calculates offsets into the kmalloc-ed memory buffer using macros from valign.h. Signed-off-by: Behan

[PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-30 Thread Behan Webster
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch instead calculates offsets into the kmalloc-ed memory buffer using macros from valign.h. Signed-off-by: Behan