Re: [PATCH V2 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-06-14 Thread Vijay Viswanath
Hi Stephen, On 6/13/2018 5:06 AM, Stephen Boyd wrote: Quoting Vijay Viswanath (2018-05-29 02:52:39) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 4050c99..2a66aa0 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -226,6 +226,24 @@ s

Re: [PATCH V2 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-06-12 Thread Stephen Boyd
Quoting Vijay Viswanath (2018-05-29 02:52:39) > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 4050c99..2a66aa0 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -226,6 +226,24 @@ struct sdhci_msm_offset { > .core_ddr_con

Re: [PATCH V2 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-06-11 Thread Evan Green
On Tue, Jun 5, 2018 at 11:32 PM Adrian Hunter wrote: > > On 29/05/18 12:52, Vijay Viswanath wrote: > > In addition to offsets of certain registers changing, the registers in > > core_mem have been shifted to HC mem as well. To access these > > registers, define msm version specific functions. Thes

Re: [PATCH V2 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-06-05 Thread Adrian Hunter
On 29/05/18 12:52, Vijay Viswanath wrote: > In addition to offsets of certain registers changing, the registers in > core_mem have been shifted to HC mem as well. To access these > registers, define msm version specific functions. These functions can > be loaded into the function pointers at the ti

[PATCH V2 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-05-29 Thread Vijay Viswanath
In addition to offsets of certain registers changing, the registers in core_mem have been shifted to HC mem as well. To access these registers, define msm version specific functions. These functions can be loaded into the function pointers at the time of probe based on the msm version detected. Al