Re: [PATCH V2 3/3] regulator: add MAX8907 driver

2012-08-09 Thread Laxman Dewangan
On Thursday 09 August 2012 06:30 PM, Mark Brown wrote: On Thu, Aug 09, 2012 at 05:57:03PM +0530, Laxman Dewangan wrote: On Thursday 09 August 2012 06:08 PM, Mark Brown wrote: The driver should just register all the regulators the chip has, it's useful for diagnostic purposes if nothing else. T

Re: [PATCH V2 3/3] regulator: add MAX8907 driver

2012-08-09 Thread Mark Brown
On Thu, Aug 09, 2012 at 05:57:03PM +0530, Laxman Dewangan wrote: > On Thursday 09 August 2012 06:08 PM, Mark Brown wrote: > >The driver should just register all the regulators the chip has, it's > >useful for diagnostic purposes if nothing else. > Then probably we need to update our dts file beca

Re: [PATCH V2 3/3] regulator: add MAX8907 driver

2012-08-09 Thread Laxman Dewangan
On Thursday 09 August 2012 06:08 PM, Mark Brown wrote: On Thu, Aug 09, 2012 at 05:49:49PM +0530, Laxman Dewangan wrote: There may be possibility that some of regulator node is not populated and that case, the idata will be NULL and hence regulator registration can be bypass for that regulator.

Re: [PATCH V2 3/3] regulator: add MAX8907 driver

2012-08-09 Thread Mark Brown
On Thu, Aug 09, 2012 at 05:49:49PM +0530, Laxman Dewangan wrote: > There may be possibility that some of regulator node is not > populated and that case, the idata will be NULL and hence regulator > registration can be bypass for that regulator. The driver should just register all the regulators

Re: [PATCH V2 3/3] regulator: add MAX8907 driver

2012-08-09 Thread Laxman Dewangan
On Thursday 09 August 2012 02:48 AM, Stephen Warren wrote: From: Gyungoh Yoo The MAX8907 is an I2C-based power-management IC containing voltage regulators, a reset controller, a real-time clock, and a touch-screen + for (i = 0; i< MAX8907_NUM_REGULATORS; i++) { + config.d

Re: [PATCH V2 3/3] regulator: add MAX8907 driver

2012-08-09 Thread Mark Brown
On Wed, Aug 08, 2012 at 03:18:47PM -0600, Stephen Warren wrote: > +static struct regulator_desc max8907_regulators[] = { > + REG_MBATT(), > + REG_LDO(SD1, "in-v1", MAX8907_REG_SDCTL1, 65, 2225000, 25000), > +#define MATCH(_name, _id) \ > + { \ > + .name = #_name, \ > +

[PATCH V2 3/3] regulator: add MAX8907 driver

2012-08-08 Thread Stephen Warren
From: Gyungoh Yoo The MAX8907 is an I2C-based power-management IC containing voltage regulators, a reset controller, a real-time clock, and a touch-screen controller. The original driver was written by: * Gyungoh Yoo Various fixes and enhancements by: * Jin Park * Tom Cherry * Prashant Gaikw