Re: [PATCH V2 3/3] tuntap: don't add to waitqueue when POLLERR

2013-01-05 Thread Jason Wang
On 01/06/2013 03:37 AM, Eric Dumazet wrote: > On Sat, 2013-01-05 at 17:34 +0800, Jason Wang wrote: >> Currently, tun_chr_poll() returns POLLERR after waitqueue adding during >> device >> unregistration. This would confuse some of its user such as vhost which >> assume >> when POLLERR is returned,

Re: [PATCH V2 3/3] tuntap: don't add to waitqueue when POLLERR

2013-01-05 Thread Eric Dumazet
On Sat, 2013-01-05 at 17:34 +0800, Jason Wang wrote: > Currently, tun_chr_poll() returns POLLERR after waitqueue adding during device > unregistration. This would confuse some of its user such as vhost which assume > when POLLERR is returned, it wasn't added to the waitqueue. Fix this by > returnin

[PATCH V2 3/3] tuntap: don't add to waitqueue when POLLERR

2013-01-05 Thread Jason Wang
Currently, tun_chr_poll() returns POLLERR after waitqueue adding during device unregistration. This would confuse some of its user such as vhost which assume when POLLERR is returned, it wasn't added to the waitqueue. Fix this by returning POLLERR before adding to waitqueue. Signed-off-by: Jason W