Re: [PATCH V2 3/5] PCI: save and restore bus on parent bus reset

2016-10-02 Thread Sinan Kaya
On 9/29/2016 7:50 PM, Sinan Kaya wrote: > Hi Bjorn, > > On 9/29/2016 5:49 PM, Bjorn Helgaas wrote: >>> + } >> This pattern of "unlock, do something, relock" needs some >> justification. In general it's unsafe because the lock is protecting >> *something*, and you have to assume that something c

Re: [PATCH V2 3/5] PCI: save and restore bus on parent bus reset

2016-09-29 Thread Sinan Kaya
Hi Bjorn, On 9/29/2016 5:49 PM, Bjorn Helgaas wrote: >> +} > This pattern of "unlock, do something, relock" needs some > justification. In general it's unsafe because the lock is protecting > *something*, and you have to assume that something can change as soon > as you unlock. Maybe you kno

Re: [PATCH V2 3/5] PCI: save and restore bus on parent bus reset

2016-09-29 Thread Bjorn Helgaas
Hi Sinan, On Fri, Sep 16, 2016 at 04:06:32PM -0400, Sinan Kaya wrote: > Device states on the bus are saved and restored for all bus resets except > the one initiated through pci_dev_reset. Filling the hole. > > Signed-off-by: Sinan Kaya > --- > drivers/pci/pci.c | 14 ++ > 1 file ch

[PATCH V2 3/5] PCI: save and restore bus on parent bus reset

2016-09-16 Thread Sinan Kaya
Device states on the bus are saved and restored for all bus resets except the one initiated through pci_dev_reset. Filling the hole. Signed-off-by: Sinan Kaya --- drivers/pci/pci.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index aab