Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Thu, Jul 28, 2016 at 10:15:52AM -0600, Mathieu Poirier wrote: > On 27 July 2016 at 13:26, Jiri Olsa wrote: > > On Wed, Jul 27, 2016 at 11:59:50AM -0600, Mathieu Poirier wrote: > > > > SNIP > > > >> > -PE_DRV_CFG_TERM > >> > +'@' PE_NAME '=' PE_NAME > >> > { > >> >

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Thu, Jul 28, 2016 at 10:15:52AM -0600, Mathieu Poirier wrote: > On 27 July 2016 at 13:26, Jiri Olsa wrote: > > On Wed, Jul 27, 2016 at 11:59:50AM -0600, Mathieu Poirier wrote: > > > > SNIP > > > >> > -PE_DRV_CFG_TERM > >> > +'@' PE_NAME '=' PE_NAME > >> > { > >> > struct

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 27 July 2016 at 13:26, Jiri Olsa wrote: > On Wed, Jul 27, 2016 at 11:59:50AM -0600, Mathieu Poirier wrote: > > SNIP > >> > -PE_DRV_CFG_TERM >> > +'@' PE_NAME '=' PE_NAME >> > { >> > struct parse_events_term *term; >> > >> > ABORT_ON(parse_events_term__str(,

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 27 July 2016 at 13:26, Jiri Olsa wrote: > On Wed, Jul 27, 2016 at 11:59:50AM -0600, Mathieu Poirier wrote: > > SNIP > >> > -PE_DRV_CFG_TERM >> > +'@' PE_NAME '=' PE_NAME >> > { >> > struct parse_events_term *term; >> > >> > ABORT_ON(parse_events_term__str(, >> >

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Wed, Jul 27, 2016 at 11:59:50AM -0600, Mathieu Poirier wrote: SNIP > > -PE_DRV_CFG_TERM > > +'@' PE_NAME '=' PE_NAME > > { > > struct parse_events_term *term; > > > > ABORT_ON(parse_events_term__str(, > > PARSE_EVENTS__TERM_TYPE_DRV_CFG, > > -

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Wed, Jul 27, 2016 at 11:59:50AM -0600, Mathieu Poirier wrote: SNIP > > -PE_DRV_CFG_TERM > > +'@' PE_NAME '=' PE_NAME > > { > > struct parse_events_term *term; > > > > ABORT_ON(parse_events_term__str(, > > PARSE_EVENTS__TERM_TYPE_DRV_CFG, > > -

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 26 July 2016 at 14:41, Jiri Olsa wrote: > On Fri, Jul 22, 2016 at 12:24:48PM -0600, Mathieu Poirier wrote: > > SNIP > >> > diff --git a/tools/perf/util/parse-events.y >> > b/tools/perf/util/parse-events.y >> > --- a/tools/perf/util/parse-events.y >> > +++

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 26 July 2016 at 14:41, Jiri Olsa wrote: > On Fri, Jul 22, 2016 at 12:24:48PM -0600, Mathieu Poirier wrote: > > SNIP > >> > diff --git a/tools/perf/util/parse-events.y >> > b/tools/perf/util/parse-events.y >> > --- a/tools/perf/util/parse-events.y >> > +++ b/tools/perf/util/parse-events.y >> >

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Fri, Jul 22, 2016 at 12:24:48PM -0600, Mathieu Poirier wrote: SNIP > > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > > --- a/tools/perf/util/parse-events.y > > +++ b/tools/perf/util/parse-events.y > > @@ -602,12 +602,12 @@ PE_NAME array '=' PE_VALUE > >

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Fri, Jul 22, 2016 at 12:24:48PM -0600, Mathieu Poirier wrote: SNIP > > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > > --- a/tools/perf/util/parse-events.y > > +++ b/tools/perf/util/parse-events.y > > @@ -602,12 +602,12 @@ PE_NAME array '=' PE_VALUE > >

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 21 July 2016 at 08:54, Jiri Olsa wrote: > On Thu, Jul 21, 2016 at 08:44:53AM -0600, Mathieu Poirier wrote: > > SNIP > >> >> diff --git a/tools/perf/util/parse-events.l >> >> b/tools/perf/util/parse-events.l >> >> index 7a2519435da0..1f7e11a6c5b3 100644 >> >> ---

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 21 July 2016 at 08:54, Jiri Olsa wrote: > On Thu, Jul 21, 2016 at 08:44:53AM -0600, Mathieu Poirier wrote: > > SNIP > >> >> diff --git a/tools/perf/util/parse-events.l >> >> b/tools/perf/util/parse-events.l >> >> index 7a2519435da0..1f7e11a6c5b3 100644 >> >> ---

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 21 July 2016 at 08:54, Jiri Olsa wrote: > On Thu, Jul 21, 2016 at 08:44:53AM -0600, Mathieu Poirier wrote: > > SNIP > >> >> diff --git a/tools/perf/util/parse-events.l >> >> b/tools/perf/util/parse-events.l >> >> index 7a2519435da0..1f7e11a6c5b3 100644 >> >> ---

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 21 July 2016 at 08:54, Jiri Olsa wrote: > On Thu, Jul 21, 2016 at 08:44:53AM -0600, Mathieu Poirier wrote: > > SNIP > >> >> diff --git a/tools/perf/util/parse-events.l >> >> b/tools/perf/util/parse-events.l >> >> index 7a2519435da0..1f7e11a6c5b3 100644 >> >> ---

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Thu, Jul 21, 2016 at 08:44:53AM -0600, Mathieu Poirier wrote: SNIP > >> diff --git a/tools/perf/util/parse-events.l > >> b/tools/perf/util/parse-events.l > >> index 7a2519435da0..1f7e11a6c5b3 100644 > >> --- a/tools/perf/util/parse-events.l > >> +++ b/tools/perf/util/parse-events.l > >> @@

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Thu, Jul 21, 2016 at 08:44:53AM -0600, Mathieu Poirier wrote: SNIP > >> diff --git a/tools/perf/util/parse-events.l > >> b/tools/perf/util/parse-events.l > >> index 7a2519435da0..1f7e11a6c5b3 100644 > >> --- a/tools/perf/util/parse-events.l > >> +++ b/tools/perf/util/parse-events.l > >> @@

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 21 July 2016 at 01:47, Jiri Olsa wrote: > On Wed, Jul 20, 2016 at 02:38:17PM -0600, Mathieu Poirier wrote: > > SNIP > >> diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h >> index d1edbf8cc66a..8d09a976fca8 100644 >> ---

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On 21 July 2016 at 01:47, Jiri Olsa wrote: > On Wed, Jul 20, 2016 at 02:38:17PM -0600, Mathieu Poirier wrote: > > SNIP > >> diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h >> index d1edbf8cc66a..8d09a976fca8 100644 >> --- a/tools/perf/util/parse-events.h >> +++

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Wed, Jul 20, 2016 at 02:38:17PM -0600, Mathieu Poirier wrote: SNIP > +static int get_config_terms(struct list_head *head_config, > + struct list_head *head_terms) > +{ > struct parse_events_term *term; > > list_for_each_entry(term, head_config, list) { >

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Wed, Jul 20, 2016 at 02:38:17PM -0600, Mathieu Poirier wrote: SNIP > diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h > index d1edbf8cc66a..8d09a976fca8 100644 > --- a/tools/perf/util/parse-events.h > +++ b/tools/perf/util/parse-events.h > @@ -71,6 +71,7 @@ enum {

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Wed, Jul 20, 2016 at 02:38:17PM -0600, Mathieu Poirier wrote: > This patchset adds PMU driver specific configuration to the parser > infrastructure by preceding any term with the '@' letter. As such > doing something like: > > perf record -e some_event/@cfg1,@cfg2=config/ ... > > will see

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Wed, Jul 20, 2016 at 02:38:17PM -0600, Mathieu Poirier wrote: SNIP > diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h > index d1edbf8cc66a..8d09a976fca8 100644 > --- a/tools/perf/util/parse-events.h > +++ b/tools/perf/util/parse-events.h > @@ -71,6 +71,7 @@ enum {

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Wed, Jul 20, 2016 at 02:38:17PM -0600, Mathieu Poirier wrote: > This patchset adds PMU driver specific configuration to the parser > infrastructure by preceding any term with the '@' letter. As such > doing something like: > > perf record -e some_event/@cfg1,@cfg2=config/ ... > > will see

Re: [PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

On Wed, Jul 20, 2016 at 02:38:17PM -0600, Mathieu Poirier wrote: SNIP > +static int get_config_terms(struct list_head *head_config, > + struct list_head *head_terms) > +{ > struct parse_events_term *term; > > list_for_each_entry(term, head_config, list) { >

[PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

This patchset adds PMU driver specific configuration to the parser infrastructure by preceding any term with the '@' letter. As such doing something like: perf record -e some_event/@cfg1,@cfg2=config/ ... will see 'cfg1' and 'cfg2=config' being added to the list of evsel config terms. Token

[PATCH V2 3/6] perf tools: add infrastructure for PMU specific configuration

This patchset adds PMU driver specific configuration to the parser infrastructure by preceding any term with the '@' letter. As such doing something like: perf record -e some_event/@cfg1,@cfg2=config/ ... will see 'cfg1' and 'cfg2=config' being added to the list of evsel config terms. Token