Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-12-05 Thread Ulf Hansson
On Wed, 5 Dec 2018 at 07:42, Stephen Boyd wrote: > > Quoting Ulf Hansson (2018-12-03 05:38:35) > > + Stephen, Mike, Graham > > > > On Fri, 30 Nov 2018 at 12:06, Viresh Kumar wrote: > > > > > > On 30-11-18, 11:18, Ulf Hansson wrote: > > There is one a big difference while comparing with clocks,

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-12-05 Thread Ulf Hansson
On Wed, 5 Dec 2018 at 07:42, Stephen Boyd wrote: > > Quoting Ulf Hansson (2018-12-03 05:38:35) > > + Stephen, Mike, Graham > > > > On Fri, 30 Nov 2018 at 12:06, Viresh Kumar wrote: > > > > > > On 30-11-18, 11:18, Ulf Hansson wrote: > > There is one a big difference while comparing with clocks,

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-12-04 Thread Stephen Boyd
Quoting Ulf Hansson (2018-12-03 05:38:35) > + Stephen, Mike, Graham > > On Fri, 30 Nov 2018 at 12:06, Viresh Kumar wrote: > > > > On 30-11-18, 11:18, Ulf Hansson wrote: > There is one a big difference while comparing with clocks, which make > this more difficult. > > That is, in

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-12-04 Thread Stephen Boyd
Quoting Ulf Hansson (2018-12-03 05:38:35) > + Stephen, Mike, Graham > > On Fri, 30 Nov 2018 at 12:06, Viresh Kumar wrote: > > > > On 30-11-18, 11:18, Ulf Hansson wrote: > There is one a big difference while comparing with clocks, which make > this more difficult. > > That is, in

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-12-03 Thread Ulf Hansson
+ Stephen, Mike, Graham On Fri, 30 Nov 2018 at 12:06, Viresh Kumar wrote: > > On 30-11-18, 11:18, Ulf Hansson wrote: > > On Fri, 30 Nov 2018 at 10:59, Viresh Kumar wrote: > > > Sure, but the ordering of locks is always subdomain first and then master. > > > Considering the case of Qcom, we have

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-12-03 Thread Ulf Hansson
+ Stephen, Mike, Graham On Fri, 30 Nov 2018 at 12:06, Viresh Kumar wrote: > > On 30-11-18, 11:18, Ulf Hansson wrote: > > On Fri, 30 Nov 2018 at 10:59, Viresh Kumar wrote: > > > Sure, but the ordering of locks is always subdomain first and then master. > > > Considering the case of Qcom, we have

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-12-03 Thread Viresh Kumar
On 30-11-18, 10:44, Ulf Hansson wrote: > On Mon, 26 Nov 2018 at 09:10, Viresh Kumar wrote: > > +static int _genpd_reeval_performance_state(struct generic_pm_domain *genpd, > > + unsigned int state, int depth); > > + > > I don't like forward declarations

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-12-03 Thread Viresh Kumar
On 30-11-18, 10:44, Ulf Hansson wrote: > On Mon, 26 Nov 2018 at 09:10, Viresh Kumar wrote: > > +static int _genpd_reeval_performance_state(struct generic_pm_domain *genpd, > > + unsigned int state, int depth); > > + > > I don't like forward declarations

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-30 Thread Viresh Kumar
On 30-11-18, 11:18, Ulf Hansson wrote: > On Fri, 30 Nov 2018 at 10:59, Viresh Kumar wrote: > > Sure, but the ordering of locks is always subdomain first and then master. > > Considering the case of Qcom, we have two domains Cx (sub-domain) and Mx > > (master). > > > > On first genpd_power_on(Cx)

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-30 Thread Viresh Kumar
On 30-11-18, 11:18, Ulf Hansson wrote: > On Fri, 30 Nov 2018 at 10:59, Viresh Kumar wrote: > > Sure, but the ordering of locks is always subdomain first and then master. > > Considering the case of Qcom, we have two domains Cx (sub-domain) and Mx > > (master). > > > > On first genpd_power_on(Cx)

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-30 Thread Ulf Hansson
On Fri, 30 Nov 2018 at 10:59, Viresh Kumar wrote: > > On 30-11-18, 10:44, Ulf Hansson wrote: > > On Mon, 26 Nov 2018 at 09:10, Viresh Kumar wrote: > > > > > > This commit updates genpd core to start propagating performance state > > > updates to master domains that have their

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-30 Thread Ulf Hansson
On Fri, 30 Nov 2018 at 10:59, Viresh Kumar wrote: > > On 30-11-18, 10:44, Ulf Hansson wrote: > > On Mon, 26 Nov 2018 at 09:10, Viresh Kumar wrote: > > > > > > This commit updates genpd core to start propagating performance state > > > updates to master domains that have their

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-30 Thread Viresh Kumar
On 30-11-18, 10:44, Ulf Hansson wrote: > On Mon, 26 Nov 2018 at 09:10, Viresh Kumar wrote: > > > > This commit updates genpd core to start propagating performance state > > updates to master domains that have their set_performance_state() > > callback set. > > > > A genpd handles two type of

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-30 Thread Viresh Kumar
On 30-11-18, 10:44, Ulf Hansson wrote: > On Mon, 26 Nov 2018 at 09:10, Viresh Kumar wrote: > > > > This commit updates genpd core to start propagating performance state > > updates to master domains that have their set_performance_state() > > callback set. > > > > A genpd handles two type of

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-30 Thread Ulf Hansson
On Mon, 26 Nov 2018 at 09:10, Viresh Kumar wrote: > > This commit updates genpd core to start propagating performance state > updates to master domains that have their set_performance_state() > callback set. > > A genpd handles two type of performance states now. The first one is the >

Re: [PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-30 Thread Ulf Hansson
On Mon, 26 Nov 2018 at 09:10, Viresh Kumar wrote: > > This commit updates genpd core to start propagating performance state > updates to master domains that have their set_performance_state() > callback set. > > A genpd handles two type of performance states now. The first one is the >

[PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-26 Thread Viresh Kumar
This commit updates genpd core to start propagating performance state updates to master domains that have their set_performance_state() callback set. A genpd handles two type of performance states now. The first one is the performance state requirement put on the genpd by the devices and

[PATCH V2 5/5] PM / Domains: Propagate performance state updates

2018-11-26 Thread Viresh Kumar
This commit updates genpd core to start propagating performance state updates to master domains that have their set_performance_state() callback set. A genpd handles two type of performance states now. The first one is the performance state requirement put on the genpd by the devices and