Re: [PATCH V2 6/6] mmc: mmci: replace blksz_datactrlXX by get_datactrl_cfg callback

2019-03-08 Thread Ludovic BARRE
hi Russell, Ulf On 3/7/19 5:46 PM, Russell King - ARM Linux admin wrote: On Thu, Mar 07, 2019 at 05:39:02PM +0100, Ludovic Barre wrote: - if (data->flags & MMC_DATA_READ) - datactrl |= MCI_DPSM_DIRECTION; Given that this is currently an invariant between all, it doesn't

Re: [PATCH V2 6/6] mmc: mmci: replace blksz_datactrlXX by get_datactrl_cfg callback

2019-03-07 Thread Russell King - ARM Linux admin
On Thu, Mar 07, 2019 at 05:39:02PM +0100, Ludovic Barre wrote: > - if (data->flags & MMC_DATA_READ) > - datactrl |= MCI_DPSM_DIRECTION; Given that this is currently an invariant between all, it doesn't make sense to have a separate public function and combine it into the

[PATCH V2 6/6] mmc: mmci: replace blksz_datactrlXX by get_datactrl_cfg callback

2019-03-07 Thread Ludovic Barre
From: Ludovic Barre This patch allows to get datactrl configuration specific at variant. This introduce more flexibility on datactlr value. Signed-off-by: Ludovic Barre --- drivers/mmc/host/mmci.c | 31 +-- drivers/mmc/host/mmci.h | 7 --- 2 files changed, 1