Re: [PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk

2012-10-16 Thread Jingoo Han
On Wednesday, October 17, 2012 2:33 AM Linus Walleij wrote: > > On Tue, Oct 16, 2012 at 10:25 AM, Jingoo Han wrote: > > > int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip, > > unsigned int off, samsung_gpio_pull_t pull) > > { > > @@ -599,7 +593,7 @

Re: [PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk

2012-10-16 Thread Jingoo Han
On Tuesday, October 16, 2012 6:43 PM Ryan Mallon wrote > > On 16/10/12 19:25, Jingoo Han wrote: > > > This patch uses pr_* instead of printk. Also, gpio_dbg > > is replaced with pr_debug. > > > > Signed-off-by: Ryan Mallon > > > If I recall correctly, I only offered review comments on this pat

Re: [PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk

2012-10-16 Thread Linus Walleij
On Tue, Oct 16, 2012 at 10:25 AM, Jingoo Han wrote: > int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip, > unsigned int off, samsung_gpio_pull_t pull) > { > @@ -599,7 +593,7 @@ static int samsung_gpiolib_4bit_input(struct gpio_chip > *chip, >

Re: [PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk

2012-10-16 Thread Ryan Mallon
On 16/10/12 19:25, Jingoo Han wrote: > This patch uses pr_* instead of printk. Also, gpio_dbg > is replaced with pr_debug. > > Signed-off-by: Ryan Mallon If I recall correctly, I only offered review comments on this patch, I wasn't directly involved in writing it, or in the submission process,

[PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk

2012-10-16 Thread Jingoo Han
This patch uses pr_* instead of printk. Also, gpio_dbg is replaced with pr_debug. Signed-off-by: Ryan Mallon Signed-off-by: Jingoo Han Reviewed-by: Linus Walleij --- drivers/gpio/gpio-samsung.c | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/g