Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-09-02 Thread Stephen Boyd
On 09/02, Viresh Kumar wrote: > > From: Viresh Kumar > Date: Mon, 3 Aug 2015 14:34:23 +0530 > Subject: [PATCH 2/3] PM / OPP: Prefix exported opp routines with dev_pm_opp_ > > That's the naming convention followed in most of opp core, but few > routines didn't follow this, fix them. > >

Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-09-02 Thread Viresh Kumar
On 02-09-15, 12:52, Viresh Kumar wrote: > On 01-09-15, 21:03, Pavel Machek wrote: > > Is ..._free_table opposite of ..._init_opp? If so, you might want to > > name them such that it is clear... > > Yes, it is opposite of that. Okay, so here is a new patch for this, > lemme know if this looks

Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-09-02 Thread Viresh Kumar
On 01-09-15, 21:03, Pavel Machek wrote: > Is ..._free_table opposite of ..._init_opp? If so, you might want to > name them such that it is clear... Yes, it is opposite of that. Okay, so here is a new patch for this, lemme know if this looks fine. I will then resend the whole series again..

Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-09-02 Thread Viresh Kumar
On 01-09-15, 21:03, Pavel Machek wrote: > Is ..._free_table opposite of ..._init_opp? If so, you might want to > name them such that it is clear... Yes, it is opposite of that. Okay, so here is a new patch for this, lemme know if this looks fine. I will then resend the whole series again..

Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-09-02 Thread Viresh Kumar
On 02-09-15, 12:52, Viresh Kumar wrote: > On 01-09-15, 21:03, Pavel Machek wrote: > > Is ..._free_table opposite of ..._init_opp? If so, you might want to > > name them such that it is clear... > > Yes, it is opposite of that. Okay, so here is a new patch for this, > lemme know if this looks

Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-09-02 Thread Stephen Boyd
On 09/02, Viresh Kumar wrote: > > From: Viresh Kumar > Date: Mon, 3 Aug 2015 14:34:23 +0530 > Subject: [PATCH 2/3] PM / OPP: Prefix exported opp routines with dev_pm_opp_ > > That's the naming convention followed in most of opp core, but few > routines didn't follow

Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-09-01 Thread Pavel Machek
Hi! > -EXPORT_SYMBOL_GPL(of_cpumask_init_opp_table); > +EXPORT_SYMBOL_GPL(dev_pm_opp_cpumask_init_opp); Well... it starts to be rather long and repetitive. > @@ -237,7 +237,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) >* >* OPPs might be populated at runtime,

Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-09-01 Thread Pavel Machek
Hi! > -EXPORT_SYMBOL_GPL(of_cpumask_init_opp_table); > +EXPORT_SYMBOL_GPL(dev_pm_opp_cpumask_init_opp); Well... it starts to be rather long and repetitive. > @@ -237,7 +237,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) >* >* OPPs might be populated at runtime,

[PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-08-31 Thread Viresh Kumar
That's the naming convention followed in most of opp core, but few recent additions didn't follow this, fix them. Reviewed-by: Stephen Boyd Signed-off-by: Viresh Kumar --- drivers/base/power/opp.c | 18 +- drivers/cpufreq/cpufreq-dt.c | 10 +- include/linux/pm_opp.h

[PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

2015-08-31 Thread Viresh Kumar
That's the naming convention followed in most of opp core, but few recent additions didn't follow this, fix them. Reviewed-by: Stephen Boyd Signed-off-by: Viresh Kumar --- drivers/base/power/opp.c | 18 +-