Re: [PATCH V2 net-next] fib_trie: avoid a redundant bit judgement in inflate

2013-09-29 Thread David Miller
Based upon how quickly you sent these two patches, the first of which wouldn't even compile, I have zero confidence that you actually booted and tested this patch at all. I'm not applying this until you take the time to boot and test the change in some way, and say explicitly in your commit messa

[PATCH V2 net-next] fib_trie: avoid a redundant bit judgement in inflate

2013-09-29 Thread baker . kernel
From: "baker.zhang" Because 'node' is the i'st child of 'oldnode', thus, here 'i' equals tkey_extract_bits(node->key, oldtnode->pos, oldtnode->bits) we just get 1 more bit, and need not care the detail value of this bits. Signed-off-by: baker.zhang --- net/ipv4/fib_trie.c | 9 +++-- 1 fil